RFC: Remove the very old BBCodeParser in favour of Golanka/BBCodeParser

[Simon Erkelens]

The BBCodeParser as it's currently in the core, is making me twitch. It's from 2007, a lot of legacy and unmaintained.

I would like to see this replaced with a more maintained external module. There are a few, the one most used is Golanka's module, which seems to be stable and doesn't need much updates.

A few quick-and-dirty testing shows it seems to work and handle all BBCodes fine.

[Jonathon Menz]

Do we need a BBCodeParser in core? Seems like something that should be a dependency of the forum or comments module, assuming BBCode is still relevant in a MarkDown world :)

[Sam Minnée]

The BBCode parser was there for the benefit of the forum module; it should be removed from core and the forum module updated to use an external dependency.

I'd be more relaxed about removing the functionality from code after forum has this refactoring made, if you wanted to do that, Simon?

--
You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to silverstripe-d...@googlegroups.com.
To post to this group, send email to silverst...@googlegroups.com.
Visit this group at https://groups.google.com/group/silverstripe-dev.
For more options, visit https://groups.google.com/d/optout.

--

Sam Minnée

CEO

SilverStripe Limited

[Simon Erkelens]

That actually makes sense. Because I was wondering where it was actually used.

Would mean the Parse method can be removed from core DBText as well, moved to a Forum or Comment DBText Extension?

Well see when forum is fixed on this, then move it out I guess.

[Sam Minnée]

I would probably do subclassing rather than extensions: DBBBCodeText extends DBText (inside forum is fine) and then use that field type in the forum DataObjects.

It keeps the clutter out of DBText fields used elsewhere in the system.