when using django trunk, admin_media_prefix is depreciated, yet the satchmo templates still use the admin_media_prefix
37 views
Skip to first unread message
m1chael
Feb 9, 2012, 8:04:11 PM2/9/12
to Satchmo users
just letting you guys know
hynekcer
Feb 13, 2012, 6:18:12 PM2/13/12
to Satchmo users
It looks new, that this deprecating have been discussed with Russel
Keith-Magee at the end of November for the first time.
If we change it now, Django 1.2 would be breaken, whereas Django 1.4
works now with warnings, but works. Support for the previous stable
Django version is still useful for easier upgrade of Satchmo on
existing installations. We change it after Satchmo 0.9.2 final.
m1chael, if you know a smart solution for now, write it please.
-- Hynek
Keith-Magee at the end of November for the first time.
If we change it now, Django 1.2 would be breaken, whereas Django 1.4
works now with warnings, but works. Support for the previous stable
Django version is still useful for easier upgrade of Satchmo on
existing installations. We change it after Satchmo 0.9.2 final.
m1chael, if you know a smart solution for now, write it please.
-- Hynek
Alec Taylor
Feb 13, 2012, 9:48:18 PM2/13/12
to satchm...@googlegroups.com
Can't we just add in version checking?
if VERSION > 1.4
Or whatnot?
if VERSION > 1.4
Or whatnot?
hynekcer
Feb 14, 2012, 4:59:23 PM2/14/12
to Satchmo users
Does anybody want to contribute to Satchmo for Django 1.4?
We can create a new branch for Django 1.3 and 1.4 with a minimalized
set of necessary changes compared to support for 1.2 and 1.3. Who will
want to develop a store for Django 1.4 should merge it with the actual
Satchmo trunk. After the final Satchmo 0.9.2 we can merge them
directly in the source repository.
We should not add version checking to templates
because it is not too readable.
Users customize templates mostly which would complicate upgrades.
It is easier to write later in release notes:
replace all "{% admin_media_prefix %}something"
by "{% static "admin/something" %}"
and remove all {% load adminmedia %}
then replace something very long conditional by something other very
long conditional.
Does anybody want to contribute to Satchmo for Django 1.4?
-- Hynek
We can create a new branch for Django 1.3 and 1.4 with a minimalized
set of necessary changes compared to support for 1.2 and 1.3. Who will
want to develop a store for Django 1.4 should merge it with the actual
Satchmo trunk. After the final Satchmo 0.9.2 we can merge them
directly in the source repository.
We should not add version checking to templates
because it is not too readable.
Users customize templates mostly which would complicate upgrades.
It is easier to write later in release notes:
replace all "{% admin_media_prefix %}something"
by "{% static "admin/something" %}"
and remove all {% load adminmedia %}
then replace something very long conditional by something other very
long conditional.
Does anybody want to contribute to Satchmo for Django 1.4?
-- Hynek
Reply all
Reply to author
Forward
0 new messages