Re: Satchmo w/ latest Sorl Thumbnail breaks

Chris Moffitt

unread,

Apr 9, 2012, 9:31:12 PM4/9/12

to satchm...@googlegroups.com

As part of the upgrade, you'll have to modify your custom templates to use the new template tags.

I have some notes here - http://www.satchmoproject.com/docs/dev/release-notes-0-9-3.html#migration-notes

-Chris

On Mon, Apr 9, 2012 at 5:48 PM, Darren Hollenbeck <dar...@softplc.com> wrote:

Tried upgrading sorl thumbnail to latest per the statement on http://www.satchmoproject.com/docs/dev/requirements.html that Satchmo 0.9.3 supported it.

I get the following error on the index page:

Template error:
In template /usr/lib/python2.6/site-packages/Satchmo-0.9.3-py2.6.egg/satchmo_store/shop/templates/shop/index.html, error at line 22

Invalid block tag: 'endif', expected 'empty' or 'endthumbnail'
12 :
13 : {% if all_products_list %}
14 : <h4>{% trans "Featured Items" %}</h4>
15 : {% for product in all_products_list %}
16 : <div class = "productImage">
17 : {% if product.main_image %}
18 : <center>
19 : {% thumbnail product.main_image.picture 85x85 as image %}

20 : <a href="{{ product.get_absolute_url }}"><img src="{{ image }}" width="{{ image.width }}" height="{{ image.height }}" /></a>

21 : </center>
22 : {% endif %}
23 : <p><a href="{{ product.get_absolute_url }}">{{ product.translated_name }}</a></p>
24 : </div>

25 : {% endfor %}
26 : {% endif %}
27 :
28 : {% if is_paginated %}
29 : <div id = "pagination">

30 : <ul>
31 : {% if page_obj.has_previous %}
32 : <li> <a href="{{shop_base}}/?page={{page_obj.previous_page_number}}">{% trans "Previous" %}</a> </li>

--
You received this message because you are subscribed to the Google Groups "Satchmo users" group.
To view this discussion on the web visit https://groups.google.com/d/msg/satchmo-users/-/a64FmwsIVMYJ.
To post to this group, send email to satchm...@googlegroups.com.
To unsubscribe from this group, send email to satchmo-user...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/satchmo-users?hl=en.

Darren Hollenbeck

unread,

Apr 10, 2012, 9:34:21 AM4/10/12

to satchm...@googlegroups.com

Yeah I found the issue a few minutes after I posted, so deleted the message. Oops!

Just needed to move my version of Satchmo forward a few revs (I was at the initial 0.9.3 version change mark)

On Monday, April 9, 2012 8:31:12 PM UTC-5, Chris Moffitt wrote:

As part of the upgrade, you'll have to modify your custom templates to use the new template tags.

I have some notes here - http://www.satchmoproject.com/docs/dev/release-notes-0-9-3.html#migration-notes

-Chris

To unsubscribe from this group, send email to satchmo-users+unsubscribe@googlegroups.com.

hynekcer

unread,

Apr 11, 2012, 4:46:23 PM4/11/12

to Satchmo users

I found that Sorl thumbnal v. 11 fails on our default image
"satchmo/static/images/productimage-picture-default.jpg"
I reported it to them https://github.com/sorl/sorl-thumbnail/issues/98

I hope that it is the last bug related to staticfiles, images and
similar after the latest changes and that my big changesets with fixes
are coming soon,

--Hynek

On 10 dub, 15:34, Darren Hollenbeck <dar...@softplc.com> wrote:
> Yeah I found the issue a few minutes after I posted, so deleted the
> message. Oops!
>
> Just needed to move my version of Satchmo forward a few revs (I was at the
> initial 0.9.3 version change mark)
>
>
>
>
>
>
>
> On Monday, April 9, 2012 8:31:12 PM UTC-5, Chris Moffitt wrote:
>
> > As part of the upgrade, you'll have to modify your custom templates to use
> > the new template tags.
>
> > I have some notes here -

> >http://www.satchmoproject.com/docs/dev/release-notes-0-9-3.html#migra...

>
> > -Chris
>
> > On Mon, Apr 9, 2012 at 5:48 PM, Darren Hollenbeck wrote:
>
> >> Tried upgrading sorl thumbnail to latest per the statement on

> >>http://www.satchmoproject.com/docs/dev/requirements.htmlthat Satchmo

> >> satchmo-user...@googlegroups.com.

hynekcer

unread,

Apr 11, 2012, 4:55:18 PM4/11/12

to Satchmo users

Can anybody fix the image
satchmo/static/images/productimage-picture-default.jpg
i.e. remove EXIF or fix it?

We can not wait for their next version on pypi.

--Hynek

On 11 dub, 22:46, hynekcer <hy...@sdb.cz> wrote:
> I found that Sorl thumbnal v. 11 fails on our default image
> "satchmo/static/images/productimage-picture-default.jpg"

> I reported it to themhttps://github.com/sorl/sorl-thumbnail/issues/98

Chris Moffitt

unread,

Apr 11, 2012, 5:06:36 PM4/11/12

to satchm...@googlegroups.com

Ahh. I'm glad you figured that out. I noticed some odd behavior there and couldn't figure it out. It might be worthwhile to add a dummy exif info to our file just for now until the patch is implemented.

-Chris

Darren Hollenbeck

unread,

Apr 12, 2012, 12:01:23 PM4/12/12

to satchm...@googlegroups.com

I'm not too familiar with the jpeg stuff (no idea what EXIF is), but I was able to get Sorl thumbnail v11 working with that image by installing the libjpeg-devel package onto my system. Without the dev package it gave me the same key error.

Don't know if that info helps.

On Wednesday, April 11, 2012 4:06:36 PM UTC-5, Chris Moffitt wrote:

Ahh. I'm glad you figured that out. I noticed some odd behavior there and couldn't figure it out. It might be worthwhile to add a dummy exif info to our file just for now until the patch is implemented.

-Chris

> >> satchmo-users+unsubscribe@googlegroups.com.

> >> For more options, visit this group at
> >>http://groups.google.com/group/satchmo-users?hl=en.

--
You received this message because you are subscribed to the Google Groups "Satchmo users" group.
To post to this group, send email to satchm...@googlegroups.com.

To unsubscribe from this group, send email to satchmo-users+unsubscribe@googlegroups.com.

hynekcer

unread,

Apr 12, 2012, 1:13:07 PM4/12/12

to Satchmo users

Thanks for info. It is combination of the same exception unhandled in
more packages. New Sorl tries intelligently rotate images according
exif info stored by difital camera. PIL is the origin of bug and they
fixed it in PIL 1.1.7 by adding the same try/except/pass block as I
did for development version of sorl-thumbnail and sent with bugreport.
Sorl accept three engines, not only PIL. There are many solutions and
some are overkill if anything must be required from user.

--Hynek

On 12 dub, 18:01, Darren Hollenbeck <dar...@softplc.com> wrote:
> I'm not too familiar with the jpeg stuff (no idea what EXIF is), but I was
> able to get Sorl thumbnail v11 working with that image by installing the
> libjpeg-devel package onto my system. Without the dev package it gave me
> the same key error.
>
> Don't know if that info helps.
>
>
>
>
>
>
>
> On Wednesday, April 11, 2012 4:06:36 PM UTC-5, Chris Moffitt wrote:
>
> > Ahh. I'm glad you figured that out. I noticed some odd behavior there and
> > couldn't figure it out. It might be worthwhile to add a dummy exif info to
> > our file just for now until the patch is implemented.
>
> > -Chris
>
> > On Wed, Apr 11, 2012 at 3:46 PM, hynekcer wrote:
>
> >> I found that Sorl thumbnal v. 11 fails on our default image
> >> "satchmo/static/images/productimage-picture-default.jpg"

> >> I reported it to themhttps://github.com/sorl/sorl-thumbnail/issues/98

> >> > >> satchmo-user...@googlegroups.com.

> >> > >> For more options, visit this group at
> >> > >>http://groups.google.com/group/satchmo-users?hl=en.
>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "Satchmo users" group.
> >> To post to this group, send email to satchm...@googlegroups.com.
> >> To unsubscribe from this group, send email to

> >> satchmo-user...@googlegroups.com.

Reply all

Reply to author

Forward