serving only controller+action specific css/javascript
102 views
Skip to first unread message
Chris Braddock
Jun 27, 2011, 1:06:36 PM6/27/11
to rubyonra...@googlegroups.com
Hi, input please!
I'm trying to dynamically serve js/css based on the active controller+action, e.g.:
<link href="/stylesheets/people/update.css" />
<script src="/javascripts/people/update.js"></script>
In application_helper.rb, I'm using the following method to create the dynamic bits of the asset URLs:
def asset_path_fragment
"#{controller.controller_name}/#{controller.action_name}"
end
Then I realized a flaw in my logic:
def update
if @something_goes_wrong
render :edit # render the #edit's view but erroneously serve the #update's css/js
end
end
So ... what should I do?
Chris Braddock
Jun 28, 2011, 9:40:51 AM6/28/11
to rubyonra...@googlegroups.com
Well, I see I can do this, but it seems like a pretty bad idea.
def update
if @something_goes_wrong
self.acion_name = 'edit'
render :edit
end
end
Anyone?
Chris Kottom
Jun 28, 2011, 10:37:03 AM6/28/11
to rubyonra...@googlegroups.com
Sounds like a job for content_for. You need a snippet like this in your view template:
update.html.erb:
<% content_for :assets do %>
<%= stylesheet_link_tag "people/update" %>
<%= javascript_include_tag "people/update" %>
<% end %>
And in your layout:
...
<%= yield :assets $>
...
--To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/T7kUgXIxSscJ.
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonra...@googlegroups.com.
To unsubscribe from this group, send email to rubyonrails-ta...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
Chris Braddock
Jun 28, 2011, 10:52:09 AM6/28/11
to rubyonra...@googlegroups.com
Hmm, maybe I'm confused. Even if I used your solution verbatim I think I'm still stuck with the problem as update.html.erb would not be used (edit.html.erb would).
To recap, what you're suggesting is essentially what I'm doing -- except instead of hard-coding "people/update" I'm using a helper method that uses controller.controller_name + "/" + controller.action_name to generate that part of the path.
So far so good, but when I use "render :edit" in the "update" action, I've got my problem (I'm requesting the wrong action's assets).
Chris Kottom
Jun 28, 2011, 11:21:23 AM6/28/11
to rubyonra...@googlegroups.com
No, in the solution I suggested the decision about which assets to use is made in the template and can't depend on the controller name/action. There's no way that I know of to determine the template name in the same way via a helper function.
The only other option that might be useful for you would be to have combined CSS/JS files for some actions where this type of thing can occur like with update/edit and set the ID or class of the <body> tag based on the template rendered. You could then target selectors in your assets to ensure the correct behavior, but this might end up being more effort than a simpler solution.
--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/2LGOmrUizjYJ.
Chris Braddock
Jun 28, 2011, 11:29:31 AM6/28/11
to rubyonra...@googlegroups.com
Thanks. The 2nd option you're suggesting (body IDs) is what I originally had in mind until this debate broke out against using the ID attribute on the body tag (which I kind of ended up liking).
But, for the sake of pragmatism, I might have to again revisit my approach thanks to this new twist.
Martin Wawrusch
Jun 28, 2011, 11:32:09 AM6/28/11
to rubyonra...@googlegroups.com
Just to add my two cents, the body approach works well as long as you work with classes, not a single id, not with the id. Something like action_youractionname and controller_yourcontrollername. Modernizr has a similar approach to specify what features are available.
On Tue, Jun 28, 2011 at 8:29 AM, Chris Braddock <braddoc...@gmail.com> wrote:
Thanks. The 2nd option you're suggesting (body IDs) is what I originally had in mind until this debate broke out against using the ID attribute on the body tag (which I kind of ended up liking).But, for the sake of pragmatism, I might have to again revisit my approach thanks to this new twist.
--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/u6YFgqb4qXgJ.
Chris Braddock
Jun 28, 2011, 11:34:45 AM6/28/11
to rubyonra...@googlegroups.com
Cool, I'll check it out - thanks again.
Martin Wawrusch
Jun 28, 2011, 11:38:38 AM6/28/11
to rubyonra...@googlegroups.com
Here is my code:
%body{ :class => "controller_#{controller.controller_name} #{defined?(@page_cssclass) ? @page_cssclass : ''}" }
I am using a custom page_css class set in the controller action method here instead of an action name, but I would use an action name instead these days
On Tue, Jun 28, 2011 at 8:34 AM, Chris Braddock <braddoc...@gmail.com> wrote:
Cool, I'll check it out - thanks again.
--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/e5K-RSa0LvUJ.
Chirag Singhal
Jun 28, 2011, 12:14:44 PM6/28/11
to rubyonra...@googlegroups.com
This may look like a quick and dirty way to do this, but might work with minimal effort.
Also, this will work only in the scenario where create and update never have their own views - this would be the case most often, but just wanted to highlight it
def asset_path_fragment
css_action = case controller.action_name
when "create"
"new"
when "update"
"edit"
else
controller.action_name
end
"#{controller.controller_name}/#{css_action}"
end
Reply all
Reply to author
Forward
0 new messages