Pull request nag for PostgreSQL auto-reconnect fix

113 views
Skip to first unread message

Steve Jorgensen

unread,
Jun 19, 2012, 1:18:57 PM6/19/12
to Ruby on Rails: Core
Hi all,

A while ago, I posted a pull request for PostgreSQL auto-reconnect,
got some feedback on that, went back and tried again. I have had a
second pull request up for quite a while now including tests that
reveal the failure to reconnect (still broken or re-broken after
#6477) and a fix for that problem.

This fixes a currently open issue for my employer if I can get it
accepted and subsequently get that applied to the Rails versions our
applications are using.

I'm still waiting to have my pull request accepted or rejected.

Steve Klabnik

unread,
Jun 19, 2012, 2:39:56 PM6/19/12
to rubyonra...@googlegroups.com
Since you didn't actually link to it, you mean
https://github.com/rails/rails/pull/6654 right?

You can always use bundler to apply your patch to Rails and use it
until it gets merged or not.

Steve Jorgensen

unread,
Jun 20, 2012, 12:25:27 PM6/20/12
to rubyonra...@googlegroups.com
Yes that's the link. Sorry I omitted it.

I know I can just use the patch. Seems best to get the test coverage into the Rails core ASAP though, so the functionality doesn't keep getting re-broken in new ways, and I don't have to keep writing new fixes.
Reply all
Reply to author
Forward
0 new messages