Hi,
today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:
https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharing
Flogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:
https://github.com/google/flogger
https://google.github.io/flogger/
Benefits:
- Better Readability
- Better Performance
- Extensible API
- Will allow us to implement request tracing
Flogger API examples:
logger.atSevere() .withCause(err) .log("Error in %s %s", req.getMethod(), uri);Hi, going to https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharing it shows that it is invite based.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Will this support sending logs to logstash?And also because of the migration to another logger and the fact that log4j on logstash is being removed, will this support gelf?
Or will we develop a logstash plugin for flogger?
On Tuesday, April 17, 2018 at 3:56:50 PM UTC+1, Edwin Kempin wrote:Hi,
today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:
https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharing
Flogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:
https://github.com/google/flogger
https://google.github.io/flogger/
Benefits:
- Better Readability
- Better Performance
- Extensible API
- Will allow us to implement request tracing
Flogger API examples:
logger.atSevere() .withCause(err) .log("Error in %s %s", req.getMethod(), uri);logger.atInfo().atMostEvery(1, TimeUnit.HOURS).log(...)logger.atInfo().withStackTrace(StackSize.FULL).log(...)The idea is to use Flogger with a (yet to be written) log4j backend so that existing log4 configuration files continue to work.Within Google Flogger is long-established and used by many projects.Please let me know if you have any concerns about this.I'm also looking for volunteers to help with the migration effort. So if this sounds interesting to you and you have time to help with this please let me know. One of the first things to do would be to write a log4j backend for Flogger (estimated effort ~2weeks).Edwin
Hi,
today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:
https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharing
Flogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:
https://github.com/google/flogger
https://google.github.io/flogger/
Benefits:
- Better Readability
- Better Performance
- Extensible API
- Will allow us to implement request tracing
Flogger API examples:
logger.atSevere() .withCause(err) .log("Error in %s %s", req.getMethod(), uri);logger.atInfo().atMostEvery(1, TimeUnit.HOURS).log(...)logger.atInfo().withStackTrace(StackSize.FULL).log(...)
The idea is to use Flogger with a (yet to be written) log4j backend so that existing log4 configuration files continue to work.Within Google Flogger is long-established and used by many projects.Please let me know if you have any concerns about this.I'm also looking for volunteers to help with the migration effort. So if this sounds interesting to you and you have time to help with this please let me know. One of the first things to do would be to write a log4j backend for Flogger (estimated effort ~2weeks).Edwin
-Matthias
On 17 Apr 2018, at 22:33, Matthias Sohn <matthi...@gmail.com> wrote:
On Tue, Apr 17, 2018 at 4:56 PM, 'Edwin Kempin' via Repo and Gerrit Discussion <repo-discuss@googlegroups.com> wrote:Hi,today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharingFlogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:
Benefits:- Better Readability- Better Performance- Extensible API- Will allow us to implement request tracingFlogger API examples:logger.atSevere() .withCause(err) .log("Error in %s %s", req.getMethod(), uri);logger.atInfo().atMostEvery(1, TimeUnit.HOURS).log(...)logger.atInfo().withStackTrace(StackSize.FULL).log(...)looks like a good improvementThe idea is to use Flogger with a (yet to be written) log4j backend so that existing log4 configuration files continue to work.Within Google Flogger is long-established and used by many projects.Please let me know if you have any concerns about this.I'm also looking for volunteers to help with the migration effort. So if this sounds interesting to you and you have time to help with this please let me know. One of the first things to do would be to write a log4j backend for Flogger (estimated effort ~2weeks).Edwinwould it make sense to also adopt flogger in jgit ?+1 IMHO. It is crucial to have a consistent way of logging throughout the Gerrit stack, including JGit :-)
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
Welcome Flogger !Luca.-Matthias--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
Currently log4j works with logstash by using SocketAppender
but logstash is removing that plugin for security reasons. And for integrating gelf you include https://gerrit-review.googlesource.com/c/gerrit/+/146214
On Tue, Apr 17, 2018 at 11:36 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:
On 17 Apr 2018, at 22:33, Matthias Sohn <matthi...@gmail.com> wrote:
On Tue, Apr 17, 2018 at 4:56 PM, 'Edwin Kempin' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:Hi,today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharingFlogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:
is the binary available on some central artefact repository like Maven central ?This one has a strange groupId which I wouldn't expect from a google open source project
Benefits:- Better Readability- Better Performance- Extensible API- Will allow us to implement request tracingFlogger API examples:logger.atSevere() .withCause(err) .log("Error in %s %s", req.getMethod(), uri);logger.atInfo().atMostEvery(1, TimeUnit.HOURS).log(...)logger.atInfo().withStackTrace(StackSize.FULL).log(...)looks like a good improvementThe idea is to use Flogger with a (yet to be written) log4j backend so that existing log4 configuration files continue to work.Within Google Flogger is long-established and used by many projects.Please let me know if you have any concerns about this.I'm also looking for volunteers to help with the migration effort. So if this sounds interesting to you and you have time to help with this please let me know. One of the first things to do would be to write a log4j backend for Flogger (estimated effort ~2weeks).Edwinwould it make sense to also adopt flogger in jgit ?+1 IMHO. It is crucial to have a consistent way of logging throughout the Gerrit stack, including JGit :-)ok, I can look into this part
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
Also log4j.xml must also be supported too alongside log4j.properties.
On Wed, Apr 18, 2018 at 12:20 AM Matthias Sohn <matthi...@gmail.com> wrote:On Tue, Apr 17, 2018 at 11:36 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:On 17 Apr 2018, at 22:33, Matthias Sohn <matthi...@gmail.com> wrote:On Tue, Apr 17, 2018 at 4:56 PM, 'Edwin Kempin' via Repo and Gerrit Discussion <repo-discuss@googlegroups.com> wrote:Hi,today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharingFlogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:is the binary available on some central artefact repository like Maven central ?This one has a strange groupId which I wouldn't expect from a google open source projectThese are indeed not the correct artifacts.I think the Flogger artifacts are not yet published to Maven Central, but this should happen soon.
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
On Wed, Apr 18, 2018 at 10:24 AM, Edwin Kempin <eke...@google.com> wrote:On Wed, Apr 18, 2018 at 12:20 AM Matthias Sohn <matthi...@gmail.com> wrote:On Tue, Apr 17, 2018 at 11:36 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:On 17 Apr 2018, at 22:33, Matthias Sohn <matthi...@gmail.com> wrote:On Tue, Apr 17, 2018 at 4:56 PM, 'Edwin Kempin' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:Hi,today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharingFlogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:is the binary available on some central artefact repository like Maven central ?This one has a strange groupId which I wouldn't expect from a google open source projectThese are indeed not the correct artifacts.I think the Flogger artifacts are not yet published to Maven Central, but this should happen soon.For JGit we need to add the library to the Orbit project for signing it with the Eclipse certificate,for that we'd ideally download the binary artefact from Maven central.
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
On Wed, Apr 18, 2018 at 5:33 PM Matthias Sohn <matthi...@gmail.com> wrote:On Wed, Apr 18, 2018 at 10:24 AM, Edwin Kempin <eke...@google.com> wrote:On Wed, Apr 18, 2018 at 12:20 AM Matthias Sohn <matthi...@gmail.com> wrote:On Tue, Apr 17, 2018 at 11:36 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:On 17 Apr 2018, at 22:33, Matthias Sohn <matthi...@gmail.com> wrote:On Tue, Apr 17, 2018 at 4:56 PM, 'Edwin Kempin' via Repo and Gerrit Discussion <repo-discuss@googlegroups.com> wrote:Hi,today at the hackathon I presented the idea to use a new logging framework, Flogger, for Gerrit:https://docs.google.com/presentation/d/1mE6Gc3Tb0cqYRjFk1FRg-5QsgceEHlDlZKewNBRydjY/edit?usp=sharingFlogger is an open source project (Apache 2 License) from Google that provides a fluent JAVA API for logging:is the binary available on some central artefact repository like Maven central ?This one has a strange groupId which I wouldn't expect from a google open source projectThese are indeed not the correct artifacts.I think the Flogger artifacts are not yet published to Maven Central, but this should happen soon.For JGit we need to add the library to the Orbit project for signing it with the Eclipse certificate,for that we'd ideally download the binary artefact from Maven central.The flogger artifacts are now available on Maven Central. The group ID is com.google.flogger:
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
I wonder if this is a perfect time to update to log4j2 and make a log4j2 backend for flogger?
log4j2/src/main/java/com/google/common/flogger/backend/log4j2/Log4j2LoggerBackend.java:76: error: cannot find symbol
logger.callAppenders(logEntry.asLoggingEvent());
^
symbol: method callAppenders(LogEvent)