For extending server side Gerrit there are plugins and extensions, but currently I don't see any mechanism for extending GWT based ui and RPC/JSON servises. For example there is no possibility to add
new page/option to the user preference page without modifying gerrit sources. Is there any idea how such extensions can be implemented?
On Wednesday, September 26, 2012 3:39:05 PM UTC-5, Dariusz Łuksza wrote:For extending server side Gerrit there are plugins and extensions, but currently I don't see any mechanism for extending GWT based ui and RPC/JSON servises. For example there is no possibility to add
new page/option to the user preference page without modifying gerrit sources. Is there any idea how such extensions can be implemented?We currently have no solutions. The GWT UI is compiled to javascript at compile time, so plugin support is not easy. This is something I hope we can solve in the next few months.
For specific locations, such as adding a page to the user preferences page, I think it would make sense to have Gerrit's frontend ask the server for a list of titles/links to show in the collection of pages. Then plugins could inject themselves there. We could do something similar with the list of links at the top of Gerrit (My, Projects, Admin, Documentation). Other developers have expressed concern that this approach would leave the UI too cluttered & unwieldy.
Brad
--
Best regards
GSM: +48 695 192 160
Blog: http://luksza.org
LinkedIn: http://www.linkedin.com/in/dariuszluksza
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
On Thu, Sep 27, 2012 at 11:48 AM, Brad Larson <bkla...@gmail.com> wrote:
On Wednesday, September 26, 2012 3:39:05 PM UTC-5, Dariusz Łuksza wrote:For extending server side Gerrit there are plugins and extensions, but currently I don't see any mechanism for extending GWT based ui and RPC/JSON servises. For example there is no possibility to add
new page/option to the user preference page without modifying gerrit sources. Is there any idea how such extensions can be implemented?We currently have no solutions. The GWT UI is compiled to javascript at compile time, so plugin support is not easy. This is something I hope we can solve in the next few months.+1, I have said as much to Shawn on multiple occasions :)
On Thursday, September 27, 2012 1:56:31 PM UTC-5, Dave Borowitz wrote:On Thu, Sep 27, 2012 at 11:48 AM, Brad Larson <bkla...@gmail.com> wrote:
On Wednesday, September 26, 2012 3:39:05 PM UTC-5, Dariusz Łuksza wrote:For extending server side Gerrit there are plugins and extensions, but currently I don't see any mechanism for extending GWT based ui and RPC/JSON servises. For example there is no possibility to add
new page/option to the user preference page without modifying gerrit sources. Is there any idea how such extensions can be implemented?We currently have no solutions. The GWT UI is compiled to javascript at compile time, so plugin support is not easy. This is something I hope we can solve in the next few months.+1, I have said as much to Shawn on multiple occasions :)By 'solve', I'm not sure I meant completely throw out GWT :)I agree GWT means we exclude lots of HTML/CSS/JS developers, which is unfortunate. Perhaps better/more use of UiBinder[1][2] would help with that?
We currently have a (metric) ton of java code which ends up on the client side... If we switched away from GWT, what would we switch to? I'm not that familiar with all the options, but of the ones I have seen, GWT seems to be the least bad.
I’d have to disagree. I may be wrong but I imagine the vast majority of people who would consider contributing to Gerrit are likely to be java developers rather than java script developers.
One of the things that makes me much more likely to develop and contribute towards Gerrit is the fact that the end to end development of server and UI changes are in one language, I may need to learn GWT but this is likely to be much easier than learning javascript and whatever particular javascript framework is chosen.
I may be wrong and not know enough about the backend Gerrit code by I imagine that few significant UI changes can be made without also have to work on the server side java code.
Thomas