Configuring footers added to submitted change

[Igor]

Hi,

we recently changed the submit type of one of the projects to Rebase Always to add reviewer information to merged commits. However in addition to reviewer name it also adds information about service users that added custom labels existing in this project, which seems redundant. So my question is - is it possible to add only Reviewed-By without all other scores?

Thanks in advance,

Igor.

[Gert van Dijk]

I believe it's not configurable at the moment, but rather hard coded for Code-Review and Verified labels [1]. Perhaps we could make it a feature request like this:

Introduce a label.Label-Name.footerKeyOnRebase configuration for labels [2]. For rebased/cherry-picked commits on submit: if footerKeyOnRebase is set, use that as footer key, if not set (the default unless it's Code-Review), don't add it to the commit message on submit.

Not only would it make it configurable to enable/disable this footer key, but it would also allow for a better footer key for custom labels (now it just maps 1:1 with the label name).

[1] https://gerrit.googlesource.com/gerrit/+/v2.15-rc1/gerrit-server/src/main/java/com/google/gerrit/server/git/MergeUtil.java#400

[2] https://gerrit-documentation.storage.googleapis.com/Documentation/2.15/config-labels.html#label_name

[Dave Borowitz]

I think basically you can do whatever you want if you implement CommitMessageModifier.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Oswald Buddenhagen]

https://bugs.chromium.org/p/gerrit/issues/detail?id=655
http://code.qt.io/cgit/qtqa/gerrit.git/commit/?h=v2.7-56-based-v2&id=d3866a0c287b3b9b60d650fe82194ee5281558a7