Changing commit message

[Gal Paikin]

Hi all,

Whenever users revert a change, the subject of that change is suggested to be:

"Revert <Change X>".

But if you revert this change, the suggested subject is "Revert "Revert <Change X>"", and clearly if you keep doing it more than twice it doesn't scale.

The idea is to change the subject suggested to the user.

It seems like many users are already using "Revert^N" instead of "Revert" N times, and that seems to work for them.

Another suggestion is an easier to understand language like "Nth Revert" or something like that.

Also, it's possible to name them "Revert X" and "Retry X", when Retry means "revert the revert".

What are you using? Any other suggestions?

Best,

Gal

[Oswald Buddenhagen]

On Thu, Dec 19, 2019 at 06:03:14PM +0100, 'Gal Paikin' via Repo and Gerrit Discussion wrote:
>Also, it's possible to name them "Revert X" and "Retry X", when Retry
>means "revert the revert".
>

canonical would be 're-apply "X"'.

these can be reverted again, and then re-applied again:
're-apply "X" (2nd time)'

sometimes i also use "X, take n", but that generally refers to
non-verbatim re-applications, and the description then states something
like "this is based on <SHA1>, but ...".

[Jonathan Nieder]

Hi,

Gal Paikin wrote:

Whenever users revert a change, the subject of that change is suggested to be:

"Revert <Change X>".

But if you revert this change, the suggested subject is "Revert "Revert <Change X>"", and clearly if you keep doing it more than twice it doesn't scale.

https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/dc0962ee496be8e1b9feaab3ecea6f54bebff93f/src/main/resources/static/chromium-behavior.html#663 uses "Reland".

Both git.git and linux.git just use '"Revert "Revert "...'. If you want to change that convention, it might make sense to get in touch with g...@vger.kernel.org so the change can be built in to "git revert" and the world can stay consistent.

Thanks,

Jonathan

[Nasser Grainawi]

+1 for consistency

Thanks,

Jonathan

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAKokkPEnhjxN%2BJLxAEXicXF5b%2BZBQwj7Ehdo34RdAi-13eobcg%40mail.gmail.com.

[Gal Paikin]

CCed g...@vger.kernel.org

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/317D3E9E-9695-4A0F-B029-1833E54191CD%40codeaurora.org.

[Python Prog]

Good question,

 if you keep doing it more than twice it doesn't scale.

+1 for changing this behaviour,probably use RevertN ,Reapply N convention,someconvention rather than continuos "Revert Revert Revert .."