[ANNOUNCE] Gerrit 2.11.1

226 views
Skip to first unread message

David Pursehouse

unread,
Jun 12, 2015, 4:24:57 AM6/12/15
to repo-d...@googlegroups.com
Gerrit version 2.11.1 is now available.

This release includes the fixes that were done in 2.10.4 and 2.10.5,
plus various other improvements since 2.11.

Please see the release notes for more details.

Release notes:
http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.11.1.html

Download:
https://gerrit-releases.storage.googleapis.com/gerrit-2.11.1.war

Log of changes since 2.11:
https://gerrit.googlesource.com/gerrit/+log/v2.11..v2.11.1

Documentation:
http://gerrit-documentation.storage.googleapis.com/Documentation/2.11.1/index.html

Martin Waitz

unread,
Jun 12, 2015, 4:36:25 AM6/12/15
to repo-d...@googlegroups.com
Thanks! Do you also have an official SHA1 sum available?

David Pursehouse

unread,
Jun 12, 2015, 4:40:45 AM6/12/15
to Martin Waitz, repo-d...@googlegroups.com
On 06/12/2015 05:36 PM, Martin Waitz wrote:
> Thanks! Do you also have an official SHA1 sum available?
>

$ sha1sum gerrit-2.11.1.war
5dc971eb84a225e5a5739e0e9f627a4280f96dbc gerrit-2.11.1.war

Mark Derricutt

unread,
Jun 12, 2015, 5:12:57 AM6/12/15
to David Pursehouse, repo-d...@googlegroups.com
On 12 Jun 2015, at 20:24, David Pursehouse wrote:

> http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.11.1.html

Awesome. One thing I note - I don't see any mention of the patch/commit to post ALL draft comments when reviewing ( regardless of patchset - https://gerrit-review.googlesource.com/#/c/67549/ I believe? ) - is this only on master and not on 2.11.1 - shame :(

Roll on 2.12!!

--
Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt
signature.asc

David Pursehouse

unread,
Jun 12, 2015, 5:16:47 AM6/12/15
to Mark Derricutt, repo-d...@googlegroups.com
On 06/12/2015 06:12 PM, Mark Derricutt wrote:
> On 12 Jun 2015, at 20:24, David Pursehouse wrote:
>
>> http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.11.1.html
>
> Awesome. One thing I note - I don't see any mention of the patch/commit to post ALL draft comments when reviewing ( regardless of patchset - https://gerrit-review.googlesource.com/#/c/67549/ I believe? ) - is this only on master and not on 2.11.1 - shame :(
>

That change was on master and wasn't backported to stable-2.11, so no,
it's not included in 2.11.1.

Note that there were also a couple of follow-up changes after that one
to fix minor bugs.

> Roll on 2.12!!
>

Mark Derricutt

unread,
Jun 12, 2015, 5:35:18 AM6/12/15
to David Pursehouse, repo-d...@googlegroups.com
On 12 Jun 2015, at 20:24, David Pursehouse wrote:

> Please see the release notes for more details.

PS: +1000 on the release. Hope I didn't sound a bit ungrateful just then :()
signature.asc

Martin Waitz

unread,
Jun 12, 2015, 5:36:00 AM6/12/15
to repo-d...@googlegroups.com
I'm seeing one strange regression: with 2.11.1 and the download-commands plugin, there is a ~1sec latency before the download command popover is shown.

David Pursehouse

unread,
Jun 12, 2015, 6:33:24 AM6/12/15
to Martin Waitz, repo-d...@googlegroups.com
There have not been any changes on the download-commands plugin between
2.11 and 2.11.1

~/download-commands$ git log --no-merges --oneline v2.11..v2.11.1
~/download-commands$

It's possible that something in core has caused this, but from a quick
look through the log from 2.11 to 2.11.1 I can't see any obvious candidate.


> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google
> Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to repo-discuss...@googlegroups.com
> <mailto:repo-discuss...@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout.

lucamilanesio

unread,
Jun 12, 2015, 10:58:38 AM6/12/15
to repo-d...@googlegroups.com
Binary packages (Deb / Rpm) of Gerrit version 2.11.1 are now available

If you have already installed Gerrit 2.10 / 2.11 using them, you need to execute:

(on Debian / Ubuntu)
apt-get update & apt-get install gerrit

(on CentOS / RedHat)
yum clean all && yum install gerrit

If you have not configured yet the GerritForge / BinTray repositories, the instructions are on:

NOTE: The upgrade command will automatically stop Gerrit, upgrade and reindex. Once the upgrade is completed Gerrit will need to be started again manually.

Docker images of Gerrit version 2.11.1 are available on DockerHub at:

In order to fetch Gerrit with CentOS 7:
docker pull gerritforge/gerrit-centos7

In order to fetch Gerrit with Ubuntu 15.04:
docker pull gerritforge/gerrit-ubuntu15.04

NOTE: To upgrade an existing Docker instance (CentOS or Ubuntu), follow the native packages instructions (apt-get install / yum install).

Luciano Carvalho

unread,
Jun 12, 2015, 11:28:06 AM6/12/15
to David Pursehouse, repo-d...@googlegroups.com
My test server failed to start on this version, thrown the exceptions on stack trace below.

It seems to have failed when starting the plugins.

[2015-06-12 10:20:40,704] WARN  org.eclipse.jetty.util.component.AbstractLifeCycle : FAILED o.e.j.s.ServletContextHandler@7b7f0be3{/,file:/home/gerrit2/review_site/tmp/gerrit_860001898783523603_app/gerrit_war/,STARTING}: java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
        at com.gitblit.utils.JGitUtils.getByteContent(JGitUtils.java:776)
        at com.gitblit.utils.JGitUtils.getSparkleshareId(JGitUtils.java:2141)
        at com.gitblit.manager.RepositoryManager.loadRepositoryModel(RepositoryManager.java:952)
        at com.gitblit.manager.RepositoryManager.getRepositoryModel(RepositoryManager.java:715)
        at com.gitblit.manager.RepositoryManager.configureCommitCache(RepositoryManager.java:1943)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:165)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:102)
        at com.gitblit.servlet.GitblitContext.startManager(GitblitContext.java:247)
        at com.gitblit.servlet.GitblitContext.configureContext(GitblitContext.java:186)
        at com.gitblit.servlet.GitblitContext.contextInitialized(GitblitContext.java:131)
        at com.googlesource.gerrit.plugins.gitblit.GerritWicketFilter.init(GerritWicketFilter.java:94)
        at com.google.inject.servlet.FilterDefinition.init(FilterDefinition.java:112)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:99)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.load(HttpPluginServlet.java:187)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.install(HttpPluginServlet.java:161)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.init(HttpPluginServlet.java:141)
        at com.google.inject.servlet.ServletDefinition.init(ServletDefinition.java:119)
        at com.google.inject.servlet.ManagedServletPipeline.init(ManagedServletPipeline.java:82)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:103)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at org.eclipse.jetty.servlet.FilterHolder.initialize(FilterHolder.java:138)
        at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:852)
        at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298)
        at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.handler.RequestLogHandler.doStart(RequestLogHandler.java:140)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.server.Server.start(Server.java:387)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.Server.doStart(Server.java:354)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at com.google.gerrit.pgm.http.jetty.JettyServer$Lifecycle.start(JettyServer.java:124)
        at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:74)
        at com.google.gerrit.pgm.Daemon.start(Daemon.java:292)
        at com.google.gerrit.pgm.Daemon.run(Daemon.java:204)
        at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:64)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:166)
        at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:93)
        at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:50)
        at Main.main(Main.java:25)
[2015-06-12 10:20:40,705] WARN  org.eclipse.jetty.util.component.AbstractLifeCycle : FAILED org.eclipse.jetty.server.handler.RequestLogHandler@29dbcdf9: java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
        at com.gitblit.utils.JGitUtils.getByteContent(JGitUtils.java:776)
        at com.gitblit.utils.JGitUtils.getSparkleshareId(JGitUtils.java:2141)
        at com.gitblit.manager.RepositoryManager.loadRepositoryModel(RepositoryManager.java:952)
        at com.gitblit.manager.RepositoryManager.getRepositoryModel(RepositoryManager.java:715)
        at com.gitblit.manager.RepositoryManager.configureCommitCache(RepositoryManager.java:1943)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:165)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:102)
        at com.gitblit.servlet.GitblitContext.startManager(GitblitContext.java:247)
        at com.gitblit.servlet.GitblitContext.configureContext(GitblitContext.java:186)
        at com.gitblit.servlet.GitblitContext.contextInitialized(GitblitContext.java:131)
        at com.googlesource.gerrit.plugins.gitblit.GerritWicketFilter.init(GerritWicketFilter.java:94)
        at com.google.inject.servlet.FilterDefinition.init(FilterDefinition.java:112)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:99)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.load(HttpPluginServlet.java:187)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.install(HttpPluginServlet.java:161)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.init(HttpPluginServlet.java:141)
        at com.google.inject.servlet.ServletDefinition.init(ServletDefinition.java:119)
        at com.google.inject.servlet.ManagedServletPipeline.init(ManagedServletPipeline.java:82)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:103)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at org.eclipse.jetty.servlet.FilterHolder.initialize(FilterHolder.java:138)
        at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:852)
        at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298)
        at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.handler.RequestLogHandler.doStart(RequestLogHandler.java:140)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.server.Server.start(Server.java:387)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.Server.doStart(Server.java:354)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at com.google.gerrit.pgm.http.jetty.JettyServer$Lifecycle.start(JettyServer.java:124)
        at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:74)
        at com.google.gerrit.pgm.Daemon.start(Daemon.java:292)
        at com.google.gerrit.pgm.Daemon.run(Daemon.java:204)
        at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:64)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:166)
        at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:93)
        at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:50)
        at Main.main(Main.java:25)
[2015-06-12 10:20:40,708] INFO  org.eclipse.jetty.server.ServerConnector : Started ServerConnector@3c2575e9{HTTP/1.1}{0.0.0.0:8089}
[2015-06-12 10:20:40,709] WARN  org.eclipse.jetty.util.component.AbstractLifeCycle : FAILED org.eclipse.jetty.server.Server@e2c73cd: java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
        at com.gitblit.utils.JGitUtils.getByteContent(JGitUtils.java:776)
        at com.gitblit.utils.JGitUtils.getSparkleshareId(JGitUtils.java:2141)
        at com.gitblit.manager.RepositoryManager.loadRepositoryModel(RepositoryManager.java:952)
        at com.gitblit.manager.RepositoryManager.getRepositoryModel(RepositoryManager.java:715)
        at com.gitblit.manager.RepositoryManager.configureCommitCache(RepositoryManager.java:1943)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:165)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:102)
        at com.gitblit.servlet.GitblitContext.startManager(GitblitContext.java:247)
        at com.gitblit.servlet.GitblitContext.configureContext(GitblitContext.java:186)
        at com.gitblit.servlet.GitblitContext.contextInitialized(GitblitContext.java:131)
        at com.googlesource.gerrit.plugins.gitblit.GerritWicketFilter.init(GerritWicketFilter.java:94)
        at com.google.inject.servlet.FilterDefinition.init(FilterDefinition.java:112)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:99)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.load(HttpPluginServlet.java:187)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.install(HttpPluginServlet.java:161)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.init(HttpPluginServlet.java:141)
        at com.google.inject.servlet.ServletDefinition.init(ServletDefinition.java:119)
        at com.google.inject.servlet.ManagedServletPipeline.init(ManagedServletPipeline.java:82)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:103)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at org.eclipse.jetty.servlet.FilterHolder.initialize(FilterHolder.java:138)
        at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:852)
        at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298)
        at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.handler.RequestLogHandler.doStart(RequestLogHandler.java:140)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.server.Server.start(Server.java:387)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.Server.doStart(Server.java:354)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at com.google.gerrit.pgm.http.jetty.JettyServer$Lifecycle.start(JettyServer.java:124)
        at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:74)
        at com.google.gerrit.pgm.Daemon.start(Daemon.java:292)
        at com.google.gerrit.pgm.Daemon.run(Daemon.java:204)
        at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:64)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:166)
        at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:93)
        at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:50)
        at Main.main(Main.java:25)
[2015-06-12 10:20:40,709] ERROR com.google.gerrit.pgm.Daemon : Unable to start daemon
java.lang.NoSuchMethodError: org.eclipse.jgit.treewalk.TreeWalk.release()V
        at com.gitblit.utils.JGitUtils.getByteContent(JGitUtils.java:776)
        at com.gitblit.utils.JGitUtils.getSparkleshareId(JGitUtils.java:2141)
        at com.gitblit.manager.RepositoryManager.loadRepositoryModel(RepositoryManager.java:952)
        at com.gitblit.manager.RepositoryManager.getRepositoryModel(RepositoryManager.java:715)
        at com.gitblit.manager.RepositoryManager.configureCommitCache(RepositoryManager.java:1943)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:165)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:102)
        at com.gitblit.servlet.GitblitContext.startManager(GitblitContext.java:247)
        at com.gitblit.servlet.GitblitContext.configureContext(GitblitContext.java:186)
        at com.gitblit.servlet.GitblitContext.contextInitialized(GitblitContext.java:131)
        at com.googlesource.gerrit.plugins.gitblit.GerritWicketFilter.init(GerritWicketFilter.java:94)
        at com.google.inject.servlet.FilterDefinition.init(FilterDefinition.java:112)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:99)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.load(HttpPluginServlet.java:187)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.install(HttpPluginServlet.java:161)
        at com.google.gerrit.httpd.plugins.HttpPluginServlet.init(HttpPluginServlet.java:141)
        at com.google.inject.servlet.ServletDefinition.init(ServletDefinition.java:119)
        at com.google.inject.servlet.ManagedServletPipeline.init(ManagedServletPipeline.java:82)
        at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:103)
        at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:220)
        at org.eclipse.jetty.servlet.FilterHolder.initialize(FilterHolder.java:138)
        at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:852)
        at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298)
        at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.handler.RequestLogHandler.doStart(RequestLogHandler.java:140)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
        at org.eclipse.jetty.server.Server.start(Server.java:387)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
        at org.eclipse.jetty.server.Server.doStart(Server.java:354)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
        at com.google.gerrit.pgm.http.jetty.JettyServer$Lifecycle.start(JettyServer.java:124)
        at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:74)
        at com.google.gerrit.pgm.Daemon.start(Daemon.java:292)
        at com.google.gerrit.pgm.Daemon.run(Daemon.java:204)
        at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:64)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:166)
        at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:93)
        at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:50)
        at Main.main(Main.java:25)




--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Luca Milanesio

unread,
Jun 12, 2015, 11:39:36 AM6/12/15
to Luciano Carvalho, David Pursehouse, repo-d...@googlegroups.com
Gosh, seems more a JGit incompatibility with GitBlit :-(

Luca.

Luca Milanesio

unread,
Jun 12, 2015, 11:46:19 AM6/12/15
to Luciano Carvalho, David Pursehouse, repo-d...@googlegroups.com, James Moger
Actually this was exactly the change made to fix the memory leak: removing the release() method and using close().

Fix needed @GitBlit I guess … @James?

Luca.

Luciano Carvalho

unread,
Jun 12, 2015, 11:52:47 AM6/12/15
to Luca Milanesio, David Pursehouse, repo-d...@googlegroups.com, James Moger

Yup. Removing GitBlit makes it start.

I rolled back to 2.11 for now, people are already hooked on to the plugin, I can't remove it from production. :-)

Luca Milanesio

unread,
Jun 12, 2015, 11:54:15 AM6/12/15
to Luciano Carvalho, David Pursehouse, repo-d...@googlegroups.com, James Moger
The Gitblit fix should be easy … let me do it now and submit a PR to James :-)

Luca.

James Moger

unread,
Jun 12, 2015, 12:17:15 PM6/12/15
to Luca Milanesio, Luciano Carvalho, David Pursehouse, repo-d...@googlegroups.com
Yeah, I know.  I already have two open PRs for updating to JGit 4, but I'm not thrilled by it.

AFAIK it re-introduces the notorious isReachable bug so it's not a slam-dunk for me because I used to hit that bug *alot* in day-to-day use.

Maybe Matthias can comment.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=422988

-J


Luca Milanesio

unread,
Jun 12, 2015, 1:43:30 PM6/12/15
to James Moger, Luciano Carvalho, David Pursehouse, repo-d...@googlegroups.com
And the update to the latest of GitBlit 1.7 develop needs some extra changes to the plugin :-(

Sent from my iPhone

Luciano Carvalho

unread,
Jun 12, 2015, 2:59:59 PM6/12/15
to Luca Milanesio, Tom Wolf, James Moger, David Pursehouse, repo-d...@googlegroups.com
+Tom Wolf,
Your fork of the GitBlit Plugin also has the same issue.
I've submitted a ticket at your project page so you can track it: https://github.com/tomaswolf/gerrit-gitblit-plugin/issues/5

Luca Milanesio

unread,
Jun 12, 2015, 6:43:40 PM6/12/15
to Luciano Carvalho, Tom Wolf, James Moger, David Pursehouse, repo-d...@googlegroups.com
Hey Luciano,
the issue *is not* on the GitBlit plugins (original, fork1, forkN) but on the JGit 4.0 non-backward compatible changes.

GitBlit has not been ported to JGit 4.0 so it will not work until the pending PRs will be merged :-)

Luca.

lucamilanesio

unread,
Jun 13, 2015, 7:13:57 PM6/13/15
to repo-d...@googlegroups.com, david.pu...@sonymobile.com, tw20...@gmail.com, lsca...@gmail.com, james...@gmail.com
I've pushed patches for GitBlit [1], GitBlit plugin 2.11 [2] and Gitblit plugin 2.12-SNAPSHOT [3] and included the patches for the GitBlit plugin build 2.11 [4] and master [5]. 

Everything should be back to normal now ;-) with the disclaimer of the problems pointed out by James in the e-mail thread.
If that risk is acceptable for you, you can upgrade to Gerrit 2.11.1 and use the upgraded Gitblit plugin.

HTH

Luca.


More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

lucamilanesio

unread,
Jun 16, 2015, 2:11:43 AM6/16/15
to repo-d...@googlegroups.com
[1] has been merged by James.

[2] and [3] review should be quick and then we'll have a fully restored GitBlit plugin

David Ostrovsky

unread,
Jun 16, 2015, 2:28:05 AM6/16/15
to repo-d...@googlegroups.com

Am Dienstag, 16. Juni 2015 08:11:43 UTC+2 schrieb lucamilanesio:
[1] has been merged by James.

[2] and [3] review should be quick and then we'll have a fully restored GitBlit plugin


I havn't verified, but I expect troubles with rendering of markdown files since this
change was merged: [1]. That's because gitblit is using vanilla parboiled library,
but grappa includes non-relocated parboiled library that is not compatible with
vanilla one.

There are two options to fix that:

* Migrate gitblit to use grappa as well
* Relocate parboiled stuff in ueber gitblit-plugin JAR. I think that what Tom was
after in this relocation fix in this parboiled issue: [2]


Luca Milanesio

unread,
Jun 16, 2015, 3:08:52 AM6/16/15
to David Ostrovsky, repo-d...@googlegroups.com
Hey David,
thanks for pointing this out … I’ll do a double-check on 2.11.1 and master.

Luca.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages