Re: 'Reviewed' flag

[Steffen Gebert]

You've already looked at that file in the diff view :-)

Steffen

On Oct 2, 2012, at 3:08 PM, Roman Mazur <mazur...@gmail.com> wrote:

> 'Reviewed' flag seems to be set automatically for each file in a patch set. But what does it actually mean?
>
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

[Magnus Bäck]

On Tuesday, October 02, 2012 at 09:08 EDT,

Roman Mazur <mazur...@gmail.com> wrote:

> 'Reviewed' flag seems to be set automatically for each file in a patch
> set. But what does it actually mean?

It just means that you've opened the file in the diff viewer, implying
that you've reviewed the file. You can reset the flag with the checkbox
next to "Reviewed & next" at the top left part of the diff viewer.

--
Magnus Bäck
ba...@google.com

[Martin Fick]

And you can turn off the auto reviewing feature if you want (it is a user diff preference now). If you turn it off, files will only get that check mark when you explicitly give it to them. This feature works really well with the "reviewed & next" button since the next button will skip to the next unreviewed file.

-Martin


Employee of Qualcomm Innovation Center,Inc. which is a member of Code Aurora Forum

[Saša Živkov]

On Tue, Oct 2, 2012 at 3:08 PM, Roman Mazur <mazur...@gmail.com> wrote:

'Reviewed' flag seems to be set automatically for each file in a patch set. But what does it actually mean?

 

This is a reminder for you (the reviewer) to know which files, from that patch-set,

you already reviewed and which not.