Issue 73 in re2: POSIX used as an enum value name is very collision prone

[r...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 73 by phajdan...@chromium.org: POSIX used as an enum value name
is very collision prone
http://code.google.com/p/re2/issues/detail?id=73

In re2/re2.h there is this snippet:

enum CannedOptions {
DefaultOptions = 0,
Latin1, // treat input as Latin-1 (default UTF-8)
POSIX, // POSIX syntax, leftmost-longest match
Quiet // do not log about regexp parse errors
};

In e.g. Chromium build, POSIX is a defined preprocessor symbol, causing
trouble.

It would be cool to rename it, see
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/re2/patches/rename-posix-option.patch?view=markup

[r...@googlecode.com]

Updates:
Status: WorkingAsIntended

Comment #2 on issue 73 by r...@golang.org: POSIX used as an enum value name

is very collision prone
http://code.google.com/p/re2/issues/detail?id=73

(No comment was entered for this change.)

[r...@googlecode.com]

Comment #1 on issue 73 by r...@golang.org: POSIX used as an enum value name

is very collision prone
http://code.google.com/p/re2/issues/detail?id=73

Somehow this hasn't come up before in any other uses. Given that, I'd
prefer not to change the public RE2 API. If you need to patch RE2 when
importing it into Chromium that seems fine. Arguably Chromium should
be using a less broad #define too.

Russ