gRPC support

[Stuart Douglas]

So I just thought I would create a topic to discuss gRPC and how to implement it. I think there are two routes we can go with here:

1) Create a vertx-grpc extension

This appears to be a wrapper around the normal Netty based gRPC server, that can re-use the Vert.x event loops. It does not appear to be able to share the underlying socket though, so it could not integrate with our existing HTTP later as it integrates at a Netty layer rather than the HTTP handler layer.

This approach uses the standard protobuf IDL generated code approach, so it does need a bit of setup in the build, and we would need to add something to dev mode to allow IDL's to be auth recompiled on change.

This seems like the path of least resistance, but I am not sure if it really gives the best 'Quarkified` user experience.

2) Implement our own on top of vert.x HTTP handlers

I actually did this for Undertow a while back and it was not super difficult, although I did re-use all the existing protobuf stuff. All gRPC requests can be identified by their content type, so this could just be a filter on our existing HTTP stack. 

We could also look at doing a non-IDL based approach where you can just annotate classes (e.g. Protostuff https://protostuff.github.io/docs/protostuff-runtime/) 

3) Do both, implement 1) first as it is the path of least resistance, and then look at also supporting an annotation based approach that would integrate with our existing HTTP stack when we have a bit more time.

Are there any other options I have not considered?

My preference would be to just use vertx-grpc for now, and then see if there is demand for an annotation based design in the future.

[Stuart Douglas]

Actually something I just realised is that the protobuf compiler is a native binary, so integrating it into dev mode might be tricky. 

[Harald Pehl]

I started [1], [2] a while ago, but wasn’t able to push this further due to lack of time. It’s based on Netty and comes with a server and client extension plus a small quickstart. Basically SSL and dev mode support are missing.

Now that Quarkus 1.0 is out, I could update the extensions and try to add the missing parts. 

// Harald

[1] https://github.com/quarkusio/quarkus/issues/820

[2] https://github.com/hpehl/quarkus-grpc-extension

-- 
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/71f2a0e4-4dc5-40ae-beca-712145573381%40googlegroups.com.

[Stephane Epardaud]

1) Sounds like a good plan for a start.

--

You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/2962a1e7-c040-402e-ba5f-6f892ffdc5e5%40googlegroups.com.

--

Stéphane Épardaud

[Emmanuel Bernard]

We need the IDL option to support the ecosystem that is IDL driven. Unfortunately the classes are likely used in the app itself so that's a annotation processor thing. Unless I'm mistaken.

--

[Emmanuel Bernard]

Does 1 cover gRPC clients? It's equally important. Or are all clients also servers?

On 7 Nov 2019, at 3:34, Stuart Douglas wrote:

--

[clement escoffier]

On 7 Nov 2019 at 12:15 +0100, Emmanuel Bernard <eber...@redhat.com>, wrote:

Does 1 cover gRPC clients? It's equally important. Or are all clients also servers? 

Yes: https://vertx.io/docs/vertx-grpc/java/

We would need to integrate the proto to class generation in our build system (and allows hot reload). 

Clement

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/8CF34120-B99A-4056-8706-8D26E2A838D3%40redhat.com.

[Harald Pehl]

I've updated the existing gRPC extensions [1], [2] and the gRPC quickstart [3] to Quarkus 1.0.0.CR1.

The gRPC server extension supports to annotate gRPC services and intercceptors. Currently it starts its own gRPC server (io.grpc.Server), but integration with the new HTTP layer / Vert.x should be possible.

The gRPC client extension supports to inject channels to talk to gRPC services. 

What's missing is native support for the gRPC client extension and better dev mode support. 

I don't mind if you want to start over and write an own gRPC extension based on Vert.x gRPC. Just wanted to offer my support here. 

Thanks 

Harald

[1] https://github.com/hpehl/quarkus-grpc-extension/

[2] https://github.com/hpehl/quarkus-grpc-client-extension

[3] https://github.com/hpehl/quarkus-grpc-quickstart

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/695711a8-647d-4642-9f22-0cd7f18456f3%40Spark.

[Stuart Douglas]

On Friday, 8 November 2019 02:00:13 UTC+11, Harald Pehl wrote:

I've updated the existing gRPC extensions [1], [2] and the gRPC quickstart [3] to Quarkus 1.0.0.CR1.

The gRPC server extension supports to annotate gRPC services and intercceptors. Currently it starts its own gRPC server (io.grpc.Server), but integration with the new HTTP layer / Vert.x should be possible.

The gRPC client extension supports to inject channels to talk to gRPC services. 

What's missing is native support for the gRPC client extension and better dev mode support. 

I don't mind if you want to start over and write an own gRPC extension based on Vert.x gRPC. Just wanted to offer my support here. 

I think Vert.x gRPC is very similar, AFAIK it mostly just lets you re-use the vert.x event loop with the normal gRPC server. They have not directly implemented the protocol in Vert.x.

 

To unsubscribe from this group and stop receiving emails from it, send an email to quark...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/2962a1e7-c040-402e-ba5f-6f892ffdc5e5%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.

To unsubscribe from this group and stop receiving emails from it, send an email to quark...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/8CF34120-B99A-4056-8706-8D26E2A838D3%40redhat.com.

-- 
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.

To unsubscribe from this group and stop receiving emails from it, send an email to quark...@googlegroups.com.