Issue 381 in protobuf: Do not use heap where stack can be used

[prot...@googlecode.com]

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 381 by NN14...@gmail.com: Do not use heap where stack can be
used
http://code.google.com/p/protobuf/issues/detail?id=381

In generated code you see following lines:

ImportMessageLite::default_instance_ = new ImportMessageLite();
Message1::default_instance_ = new Message1();
Message2::default_instance_ = new Message2();
...

Instead of heap a stack can be used with placement new trick.
Same as boost::optional does
http://www.boost.org/doc/libs/1_49_0/libs/optional/doc/html/index.html
You can adapt this method and decrease heap fragmentation.

[prot...@googlecode.com]

Updates:
Labels: -Type-Defect Type-Enhancement

Comment #1 on issue 381 by liuj...@google.com: Do not use heap where stack

can be used
http://code.google.com/p/protobuf/issues/detail?id=381

Marked as feature request.

[prot...@googlecode.com]

Comment #2 on issue 381 by liu...@google.com: Do not use heap where stack

can be used
http://code.google.com/p/protobuf/issues/detail?id=381

I'm looking back on the pending issues. Can you clarify what you are
proposing? How can we make this on to stacks? Do you mean we should define
static char[], and use placement new?

[prot...@googlecode.com]

Comment #3 on issue 381 by NN14...@gmail.com: Do not use heap where stack

can be used
http://code.google.com/p/protobuf/issues/detail?id=381

Yes.
You can also copy boost::optional implementation :)

[prot...@googlecode.com]

Updates:
Status: WontFix
Owner: xiaof...@google.com

Comment #4 on issue 381 by xiaof...@google.com: Do not use heap where stack
can be used
https://code.google.com/p/protobuf/issues/detail?id=381

(No comment was entered for this change.)

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings