Fix for the strongs dictionary

91 views
Skip to first unread message

scruf...@gmail.com

unread,
Dec 20, 2014, 10:37:30 AM12/20/14
to openscr...@googlegroups.com
I found a bug in the strongs dictionary:


If I create a pull request for it will someone be able to merge it?

Jesse Griffin

unread,
Dec 20, 2014, 1:47:31 PM12/20/14
to openscr...@googlegroups.com

I can merge it.

--
You received this message because you are subscribed to the Google Groups "Open Scriptures" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openscripture...@googlegroups.com.
To post to this group, send email to openscr...@googlegroups.com.
Visit this group at http://groups.google.com/group/openscriptures.
For more options, visit https://groups.google.com/d/optout.

scruf...@gmail.com

unread,
Mar 1, 2015, 6:45:17 PM3/1/15
to openscr...@googlegroups.com
Thanks. I have created a fix, but I don't have commit access. What's the best way to share the diff with you?

Jesse Griffin

unread,
Mar 1, 2015, 9:30:50 PM3/1/15
to openscr...@googlegroups.com
If you fork the repo to your own account then you can make the change, commit, and push to your repo.  Then create a pull request and I'll merge it in.


Thank you,
Jesse Griffin

scruf...@gmail.com

unread,
Mar 2, 2015, 3:40:33 PM3/2/15
to openscr...@googlegroups.com
Thanks Jesse. Pull request submitted: https://github.com/openscriptures/strongs/pull/2

Jesse Griffin

unread,
Mar 2, 2015, 5:49:40 PM3/2/15
to openscr...@googlegroups.com

Merged.

Reply all
Reply to author
Forward
0 new messages