PR pending for 2.6 and final release

73 views
Skip to first unread message

Martin Magdinier

unread,
Aug 9, 2015, 6:37:50 PM8/9/15
to openref...@googlegroups.com
Group, Tom,

Currently only Tom have the knowledge to review and merge (or ask for
changes) following pull request made by other developers. Tom is doing
this work on voluntary basis on his free time and we are all very
grateful for taking care of the project mostly alone for now more than
two years.

There is currently 17 Pull Request waiting to be merged, including 7
addressing issues part the 2.6 version. Once those merged there will be
around 12 issues left open to release the 2.6 version.

My questions / request is what can we do have those pull request
reviewed and remaining issues addressed sooner than later? Qi is helping
closing issues but it is good practice to have some-else review and
merged them. I guess there is less than a week of work left to get the
2.6 out (fixing remaining issues and building the three packages).

Tom, based on your availability, will you accept some type of sponsoring
/ bounty for this last stretch? Other suggestion to make this happen?

Thanks
Martin

JackyQ2015

unread,
Aug 11, 2015, 9:30:22 PM8/11/15
to OpenRefine Development
Tom, for the PRs, I can build them and deploy somewhere for you verification and review.

I think that will steam line the process and make the merge easier. what do you think?

Also, if someone want to me build some other PR for the 2.6 milestone, please me know.

JackyQ2015

unread,
Aug 12, 2015, 10:40:34 PM8/12/15
to OpenRefine Development

Tom, I build and deployed each PR for following 6 issues. The URL is:
http://208.75.74.214:{$issueNumber*10}
For example, the issue #1021 URL is: http://208.75.74.214:10210

Please review and let me know if there is any problem. I believe all of those PR can be merged automatically if there's no issue found.   Also if anyone can lend a hand to do some test it will also welcome. You can update the tested issue regarding the test results.


On Sunday, August 9, 2015 at 6:37:50 PM UTC-4, magdmartin wrote:

Martin Magdinier

unread,
Aug 13, 2015, 8:13:09 AM8/13/15
to openref...@googlegroups.com
Thank you Qi, I will start to test few of them today.

Do you save the log from Refine of each instance somewhere? Is it possible to make them public?

This type of hosting can also be useful to troubleshoot issue like this one: https://github.com/OpenRefine/OpenRefine/issues/1052 where the issue reporter can reproduce the bug and share log / process and confirm when fixed.

Martin
--
You received this message because you are subscribed to the Google Groups "OpenRefine Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openrefine-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

JackyQ2015

unread,
Aug 13, 2015, 9:43:55 AM8/13/15
to OpenRefine Development
Each log can be published by request.

It's a testing server only and each instance is assigned 700M RAM. The environment is Ubuntu 14.04+OpenJDK7. Since it is public one, please be aware that data set published will be visible to other users.

A complete list of URL is below:
...

magdmartin

unread,
Sep 6, 2015, 12:11:17 PM9/6/15
to OpenRefine Development
Hello,

I've been four weeks now I started this thread. Over the last 5 months (May 5), Qi have made good progress on the 2.6 submitting 7 PR closing as many issues tag for the 2.6 release. With 20 pull request open, the risk to have merge conflict when submitting new code is increasing.

As Qi is currently focus on the 2.6 release, I'd like to propose that he can merge is own pull request to help him in that process.

Martin

JackyQ2015

unread,
Sep 6, 2015, 2:14:10 PM9/6/15
to OpenRefine Development
Tom, I can follow the instruction to do a 2.6RC2 release for testing. But firstly I will take on some of the tickets which assigned to you since I can have some time to allocate for this.

If it's possible, we can have some chat on the hitchat so I can get more direction from you. How about Sep 16th, Wed, 13:00 (UTC-05:00) Eastern Time? Or let me know your availability. The link to access the open chat room is here:

There are people out there waiting for the 2.6 release for quite a while, hopeful we can work together to get this done soon.

Martin Magdinier

unread,
Sep 16, 2015, 8:53:41 PM9/16/15
to openref...@googlegroups.com
Group,

It's been now over 5 weeks that this thread is without answer (except from Qi). Qi pull request are still waiting for review and being merged.

Starting Sunday September 20, I will use my owner privileges to merge Qi pull request. We have tested them on RefinePro architecture and are confident of their quality. After discussion with Qi, we will also work on removing the freebase integration and keep working toward the 2.6 release.

As always feedbacks and comments are welcome.

Thank you
Martin
--

Thad Guidry

unread,
Sep 17, 2015, 3:00:56 AM9/17/15
to openref...@googlegroups.com
Sorry, been away (still am) on vacation in China !

I did review some of the requests and they seem fine also.  Go ahead Martin.  I do plan to thoroughly test everything once we prep for final release (as I always do).

magdmartin

unread,
Oct 5, 2015, 12:51:17 PM10/5/15
to OpenRefine Development
Qi sent last Friday the pull request to close the last issue tag for the 2.6

I plan to merged it next Wednesday (Oct 7) so Qi can start to build the RC2 kit.

Comments and feedback are welcomed.

Martin

Joe Wicentowski

unread,
Oct 5, 2015, 4:22:10 PM10/5/15
to openref...@googlegroups.com
Very exciting, Martin and Qi! Many thanks!

Joe

JackyQ2015

unread,
Oct 10, 2015, 8:52:06 PM10/10/15
to OpenRefine Development
Working on the 2.6 rc2 now. should be ready next week.

Cheers

Giovanni Tummarello

unread,
Oct 14, 2015, 2:19:02 PM10/14/15
to OpenRefine Development
\o/ great to find out about this freebase push... saying Hi and looking forward to cooperate

Tom Morris

unread,
Oct 16, 2015, 8:34:56 PM10/16/15
to OpenRefine Development
Hi everyone.  My apologies!  I'm not sure how I missed this thread, but if something similar happens in the future, could I suggest that perhaps trying a different communication strategy than just continuing to reply to an unresponsive thread?

Some possible approaches might be:
- Start a new thread in case the old one got accidentally muted
- Try a private email
- Try my Twitter account
- ... you get get the idea ...

I'll start a couple of new threads to deal with the remaining work that needs to be done for the release and the recent merger of unreviewed pull requests, but here are some quick links in the mean time:


I've finished reviewing a good chunk of the outstanding PRs and issues.  If you review a PR yourself, feel from to add a +1 or comments to it.  If you see an issue that is critical enough to be triaged into the 2.6 milestone, let us know.

Tom

JackyQ2015

unread,
Oct 16, 2015, 10:22:33 PM10/16/15
to OpenRefine Development
No problem, @tom. 

Regarding the issues you add / put back to 2.6 milestone, I agree that they are all important. But considering that they have been there for quite a while and the time may take to put place a right fix, I would suggest moving to next version is a option at current situation. 

For the one I tagged "encoding", I tagged several others as "encoding" since they could be fixed in one commit or related. That's why I moved to v2.7. In my opinion that the right patch won't be trivial in terms of code change and impact and they could worth one minor version to just improve the widespread encoding issue.

Tom Morris

unread,
Oct 17, 2015, 1:13:12 AM10/17/15
to openref...@googlegroups.com
p.s. I didn't finish everything tonight and I'm hosting a two day hackathon Saturday and Sunday, so I won't be working all weekend, but will chip away during my down time.


--
Reply all
Reply to author
Forward
0 new messages