--
You received this message because you are subscribed to the Google Groups "OpenPnP" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openpnp+u...@googlegroups.com.
To post to this group, send email to ope...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openpnp/70682f48-c546-4374-8a03-4916e6977ce9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenPnP" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openpnp+u...@googlegroups.com.
To post to this group, send email to ope...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openpnp/99675b50-03c5-4b56-a348-8f5e070bd292%40googlegroups.com.
Yeah but wouldn’t the generic “N*” wildcard be better? So when they add nozzles later, they would still match?
_Mark
To view this discussion on the web visit https://groups.google.com/d/msgid/openpnp/CA%2BQw0jwksUeXaaSf7yvvw4ZWXuC_ya8nzag57dY8TRoGAprwjg%40mail.gmail.com.
Ah I see, this isn't a real wildcard matchup:
public Axis getAxis(HeadMountable hm, Axis.Type type) {
for (Axis axis : axes) {
if (axis.getType() == type && (axis.getHeadMountableIds().contains("*")
|| axis.getHeadMountableIds().contains(hm.getId()))) {
return axis;
}
}
return null;
}
https://github.com/openpnp/openpnp/blob/0bfe717a8a0bf8fd34b88edba95f314c72cddb7a/src/main/java/org/openpnp/machine/reference/driver/GcodeDriver.java#L387
That would have to be added...
_Mark
--
You received this message because you are subscribed to the Google Groups "OpenPnP" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openpnp+u...@googlegroups.com.
To post to this group, send email to ope...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openpnp/c77f07c5-cdaf-41fd-ace4-3c54366ad153%40googlegroups.com.
Hi Mark,Yep, you found it :)Easy enough to make that a more useful wildcard, or probably just use a regex to make it even more flexible.I've filed an issue for this: https://github.com/openpnp/openpnp/issues/752Jason
On Thu, Jul 12, 2018 at 11:15 AM ma...@makr.zone <ma...@makr.zone> wrote:
--Ah I see, this isn't a real wildcard matchup:
public Axis getAxis(HeadMountable hm, Axis.Type type) {
for (Axis axis : axes) {
if (axis.getType() == type && (axis.getHeadMountableIds().contains("*")
|| axis.getHeadMountableIds().contains(hm.getId()))) {
return axis;
}
}
return null;
}
https://github.com/openpnp/openpnp/blob/0bfe717a8a0bf8fd34b88edba95f314c72cddb7a/src/main/java/org/openpnp/machine/reference/driver/GcodeDriver.java#L387
That would have to be added...
_Mark
You received this message because you are subscribed to the Google Groups "OpenPnP" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openpnp+unsubscribe@googlegroups.com.
> This is fixed now: https://github.com/openpnp/openpnp/issues/752
Great :)