Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

<Regression> Mozilla-Inbound-Non-PGO - Dromaeo (DOM) - XP - 2.87%

13 views
Skip to first unread message

nob...@cruncher.build.mozilla.org

unread,
Dec 21, 2012, 1:41:44 PM12/21/12
to dev-tree-...@lists.mozilla.org
Regression: Mozilla-Inbound-Non-PGO - Dromaeo (DOM) - XP - 2.87% decrease
-------------------------------------------------------------------------
Previous: avg 193.473 stddev 1.590 of 30 runs up to revision e797fe5eb621
New : avg 187.920 stddev 1.170 of 5 runs since revision 9edcce2eabae
Change : -5.553 (2.87% / z=3.493)
Graph : http://mzl.la/12EGt8M

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e797fe5eb621&tochange=9edcce2eabae

Changesets:
* http://hg.mozilla.org/integration/mozilla-inbound/rev/41c781b02e4b
: Kartikaya Gupta <kgu...@mozilla.com> - Bug 807447 - Respect the initial-scale meta-viewport property on initial page load. r=mbrubeck
: http://bugzilla.mozilla.org/show_bug.cgi?id=807447

* http://hg.mozilla.org/integration/mozilla-inbound/rev/7a475450b0cd
: Kartikaya Gupta <kgu...@mozilla.com> - Bug 666600 - Add a pref to control the default fallback zoom level of pages. r=mfinkle
: http://bugzilla.mozilla.org/show_bug.cgi?id=666600

* http://hg.mozilla.org/integration/mozilla-inbound/rev/61e9b18ee21c
: Peter Van der Beken <pet...@propagandism.org> - Fix for bug 815149 (Add support for SOWs and XBL bindings in new DOM bindings). r=bz.
: http://bugzilla.mozilla.org/show_bug.cgi?id=815149

* http://hg.mozilla.org/integration/mozilla-inbound/rev/9edcce2eabae
: Peter Van der Beken <pet...@propagandism.org> - Fix for bug 820577 (Support reparenting for new DOM binding objects). r=bholley/bz.
: http://bugzilla.mozilla.org/show_bug.cgi?id=820577

Bugs:
* http://bugzilla.mozilla.org/show_bug.cgi?id=666600 - Add an option in preferences to set the default zoom level
* http://bugzilla.mozilla.org/show_bug.cgi?id=820577 - Support reparenting for new DOM binding objects
* http://bugzilla.mozilla.org/show_bug.cgi?id=815149 - Supports SOWs and XBL in new DOM bindings
* http://bugzilla.mozilla.org/show_bug.cgi?id=807447 - initialScale not respected in meta-viewport unless user-scalable is no

Kartikaya Gupta

unread,
Dec 21, 2012, 3:17:18 PM12/21/12
to nob...@cruncher.build.mozilla.org, dev-tree-...@lists.mozilla.org
My changes were fennec-only, and are unlikely to be responsible for this
regression.

Kartikaya Gupta

unread,
Dec 21, 2012, 3:17:18 PM12/21/12
to nob...@cruncher.build.mozilla.org, dev-tree-...@lists.mozilla.org
My changes were fennec-only, and are unlikely to be responsible for this
regression.

On 12-12-21 13:41 , nob...@cruncher.build.mozilla.org wrote:

Boris Zbarsky

unread,
Dec 21, 2012, 5:21:13 PM12/21/12
to Peter Van der Beken
On 12/21/12 10:41 AM, nob...@cruncher.build.mozilla.org wrote:
> * http://hg.mozilla.org/integration/mozilla-inbound/rev/61e9b18ee21c
> : Peter Van der Beken <pet...@propagandism.org> - Fix for bug 815149 (Add support for SOWs and XBL bindings in new DOM bindings). r=bz.
> : http://bugzilla.mozilla.org/show_bug.cgi?id=815149

Almost certainly this. The check for SOW adds at least a load, a
bit-and, and a branch or two on the fast path for returning a
wrapper-cached object... It's also possible that some of the compiler's
inlining decisions here changed, of course. GetContextCompartment and
ContextFriendFields::get are inline but not always_inline. Maybe they
should be?

-Boris
0 new messages