Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

PSA: nsCSSProperty is being renamed to nsCSSPropertyID -- local patches may need updates

17 views
Skip to first unread message

Daniel Holbert

unread,
Aug 15, 2016, 7:00:21 PM8/15/16
to dev-pl...@lists.mozilla.org
Just a heads-up, for anyone working on layout / style-system-related code:

In bug 1293739 [1], Jonathan Chan has some patches that will rename the
enumerated type "nsCSSProperty" to now be named "nsCSSPropertyID"
(adding the "ID" suffix). I plan on landing his patches on inbound later
today.

It's likely that some people have local layout/style-system-related
patches that will no longer apply cleanly (or no longer compile) as a
result of this change. If you find yourself in this category, you
should be able to fix this by e.g. using a text editor to do
search-and-replace to change s/nsCSSProperty/nsCSSPropertyID/ throughout
your local patches.

(We're doing this rename in the service of implementing CSS Properties &
Values Houdini API[2]. In that bug, we'll be re-introducing
"nsCSSProperty" as a broader type that includes custom author-defined
CSS properties *as well as* our normal enumerated properties. And this
renamed nsCSSPropertyID enum-type is restricted to only include the
(enumerated) CSS properties that we have built-in support for.)

Thanks,
~Daniel

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1293739
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1273706
0 new messages