Proposal to remove devtools.loader.hotreload

[Julian Descottes]

I would like to discuss the removal of the DevTools hotreload feature.

This feature was introduced 18 months ago, and adds some hotreloading for
DevTools development. It works with CSS files and React components. To
enable it, one has to set the `devtools.loader.hotreload` preference to
true in about:config.

This feature is not tested or maintained.
The only documentation is a mention at
http://docs.firefox-dev.tools/frontend/react-tips.html
On the latest mozilla-central enabling it can easily break the debugger &
netmonitor.

Knowing all that, I would like to remove the feature from DevTools.
Is anyone actively using the feature and/or opposed to removing it?

Julian

[Brian Grinstead]

I’m in favor of removing it. By the way, I’m hoping to expose similar functionality from `./mach watch` in https://bugzilla.mozilla.org/show_bug.cgi?id=1388899, which will work cross platform and for the entire frontend (including devtools).

Brian

> _______________________________________________
> dev-developer-tools mailing list
> dev-devel...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-developer-tools

[Patrick Brosset]

Sounds good to me. Removing code always sounds good.

On Wed, Aug 23, 2017 at 12:37 AM, Brian Grinstead <bgrin...@mozilla.com>
wrote:

[Soledad Penadés]

I like the idea of having a similar functionality cross platform, so
this is a +1 from me

Question: didn't we want to run this kind of proposals through the
process here? https://github.com/devtools-html/rfcs/

Or is it not substantial enough?

Thanks

Also YAY DELETING!

sole

--
http://soledadpenades.com

[Matteo Ferretti]

+1 for removing; especially if we're going to have a similar functionality cross platform.

-- 
Matteo Ferretti

[Matteo Ferretti]

[Julian Descottes]

Thanks for the feedback!

Regarding RFCs, I totally forgot about that, so thanks for the reminder,
Sole.
Even if it's not a big architectural change, I agree we should try and use
RFCs as much as possible.

It will be easier to keep track past decisions this way. It's also easier
to share.
I'll create an RFC item and will try to add all of the comments received so
far.

[Julian Descottes]

Hi all,

Just a heads-up, I'll be landing this change tomorrow unless there is any
complaint!
https://bugzilla.mozilla.org/show_bug.cgi?id=1392998

Julian

note: re. using devtools-rfcs vs email, I intend to discuss this during
today's DevTools meeting.

On Wed, Aug 23, 2017 at 3:58 PM, Julian Descottes <jdesc...@mozilla.com>
wrote:

[Soledad Penadés]

On 29/08/2017 09:46, Julian Descottes wrote:
> Hi all,
>
> Just a heads-up, I'll be landing this change tomorrow unless there is any
> complaint!
> https://bugzilla.mozilla.org/show_bug.cgi?id=1392998

Thank you, I still have no complaint! :)

> Julian
>
> note: re. using devtools-rfcs vs email, I intend to discuss this during
> today's DevTools meeting.

Looking forward to it!

--
http://soledadpenades.com