Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

l10n repacks now that compare-locales is in the tree, thoughts and RFC

23 views
Skip to first unread message

ax...@mozilla.com

unread,
Mar 30, 2015, 6:57:20 PM3/30/15
to
Hi,

now that we have compare-locales in mozilla-central, I'd like to move forward to actually use it.

I'd like to uplift this agressively to 38, given that that's ESR, and any benefits we can reap on the automation side probably need that.

Proposal:

Make l10n-merge mandatory, and integrate it into langpack-% and installers-%. Also force-clobber the default merge dir we have in mach.

Benefit: less docs, easier for devs and automation.

Out-of-scope: Repo interactions and stuff.

Here's my current thinking:

Make l10n-merge-% a no-op.
Intergrate the mach version of that into a new rule that installers-% and langpack-% depend on.
hard-code the LOCALE_MERGEDIR to $(OBJ_TOPDIR)/$(MOZ_APP)/locales/merge-$(AB_CD)

and then repack as usual.

In the automation front, we'd be able to drop
- getting compare-locales
- clobbering the merge dir
- running l10n-merge

... I think.

Do folks agree that we can drop non-merge builds?

Is the step-size useful to developers as well as automation?

Other comments?

Axel

(Re-posted through google groups as nntp doesn't seem to post)

Gregory Szorc

unread,
Mar 30, 2015, 7:13:54 PM3/30/15
to Axel Hecht, release-e...@lists.mozilla.org, dev-b...@lists.mozilla.org
Replying to release-engineering@ since they have more skin in this game than just core build maintainers.

_______________________________________________
dev-builds mailing list
dev-b...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-builds

Justin Wood

unread,
Mar 30, 2015, 7:30:13 PM3/30/15
to Gregory Szorc, dev-builds, Axel Hecht, release-engineering
I have concerns due to how agressively you want to push this, and how even minor changes have broken l10n repacks in obscure (and sometimes big) ways through the years.

That said, my concerns stem primarily from the seeing Thunderbird and SeaMonkey break due to those changes.  I'd be fully supportive of using compare-locales as it exists in tree without those other changes though.

I also want to see l10n story in terms of build system improved so much I can forgo my gut reaction concerns if those heavily involved in this feel the discussed changes don't incur risk beyond what we'd normally incur as far as build system in a given cycle.

~Justin Wood (Callek)

On Mon, Mar 30, 2015 at 7:13 PM, Gregory Szorc <g...@mozilla.com> wrote:
Replying to release-engineering@ since they have more skin in this game
than just core build maintainers.

On Mon, Mar 30, 2015 at 3:57 PM, <ax...@mozilla.com> wrote:

> _______________________________________________
> dev-builds mailing list
> dev-b...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-builds
>
_______________________________________________
release-engineering mailing list
release-e...@lists.mozilla.org
https://lists.mozilla.org/listinfo/release-engineering

0 new messages