[whishlist] Mojo::Dom: simpler find - map - text?

[Helmut Wollmersdorfer]

Hi,

maybe I missed some more convenient methods, but here are my solutions so far:

That's a working snippet for reading out a key-value pair from an HTML table:

  for my $details ($tables[4]->find('tr')->each) {
    my ($key,$value)
       = map { $_->all_text } $details->find('td')->each;

    $result{$key} = $value;
  }

My first attempt was something like

  my ($key,$value) = $details->find('td')->each->all_text; # WRONG

which does not work.

Then I tried map and ended in something complex like this one

  my ($key,$value) = @{
     Mojo::DOM->new("<b>K</b><b>V</b>")
       ->find("b")
       ->map(sub {$_->text})
       ->to_array
  };

I still would like my first attempt, which is IMHO more natural, but maybe against technically oriented design.

Comments?

Helmut Wollmersdorfer

[sri]

This is a funny request.

    my @all = $dom->find('td')->all_text->each;

It used to work like this until we removed AUTOLOAD and stringification support from Mojo::Collection.

https://github.com/kraih/mojo/commit/6c8e9faefc23e8783fab6c6828718900df724a63

https://github.com/kraih/mojo/commit/3a29749ea383b8d61f61c51bb337a1ffd382f74b

No, i'm afraid there is no chance we will bring any of that back, there have been way too many complaints.

--

sebastian

[Helmut Wollmersdorfer]

Thx for the explanation of the history. Now I see that cluck() also has gone.

Ok, it is as it is.

[sri]

Now I see that cluck() also has gone.

There never was a cluck(), so i suspect you mean pluck(), and that one is not "gone".

    https://github.com/kraih/mojo/blob/v5.57/Changes#L4

--

sebastian

[Helmut Wollmersdorfer]

pluck() seems removed in the current version:

$ perl -Mojo -e 'Mojo::DOM->new("<b>")->find("b")->pluck()';mojo version | grep Mojo
Can't locate object method "pluck" via package "Mojo::Collection" at -e line 1.

  Mojolicious (5.77, Tiger Face)

See also

https://github.com/kraih/mojo/commit/759215c7897855ce6fe8a3cc28a33c2bed912871#diff-0c4b798f16fc7e5ac314e0dbf81858e3

Or do I understand something wron?

Helmut Wollmersdorfer

[sri]

Or do I understand something wron?

The functionality has been merged into map(), which is why is always says "...deprecated in favor of..." .

    http://mojolicio.us/perldoc/Mojo/Collection#map

--

sebastian