2.2 RC1

29 views
Skip to first unread message

Tom Cato Amundsen

unread,
Nov 19, 2012, 12:04:20 PM11/19/12
to mnemosyne-...@googlegroups.com
Please add this patch so the program runs on Pyhton 2.6. List comprehension was added for Python 2.7

Tom Cato

--- add_cards_dlg.py.orig    2012-11-19 17:55:53.710649005 +0100
+++ add_cards_dlg.py    2012-11-19 17:58:56.474647719 +0100
@@ -143,8 +143,7 @@
             self.correspondence, check_required_fact_keys=False, parent=self)
         if dlg.exec_() != QtGui.QDialog.Accepted:
             # Set correspondence so as not to erase previous data.
-            self.correspondence = {key: key \
-                for key in self.card_type.fact_keys()}
+            self.correspondence = dict((key, key) for key in self.card_type.fact_keys())
             self.card_types_widget.setCurrentIndex(self.card_type_index)
             return
         else:


--
Tom Cato Amundsen <t...@gnu.org>                 http://www.solfege.org/
GNU Solfege - free ear training    http://www.gnu.org/software/solfege/

Peter Bienstman

unread,
Nov 20, 2012, 3:33:11 AM11/20/12
to mnemosyne-...@googlegroups.com
Are you sure you are looking at the latest version from bzr?

You already sent a patch for this, and currently the code looks like this:

# Set correspondence so as not to erase previous data.
self.correspondence = {}
for key in self.card_type.fact_keys():
self.correspondence[key] = key

Peter

On 11/19/2012 06:04 PM, Tom Cato Amundsen wrote:
> Please add this patch so the program runs on Pyhton 2.6. List
> comprehension was added for Python 2.7
>
> Tom Cato
>
> --- add_cards_dlg.py.orig 2012-11-19 17:55:53.710649005 +0100
> +++ add_cards_dlg.py 2012-11-19 17:58:56.474647719 +0100
> @@ -143,8 +143,7 @@
> self.correspondence, check_required_fact_keys=False,
> parent=self)
> if dlg.exec_() != QtGui.QDialog.Accepted:
> # Set correspondence so as not to erase previous data.
> - self.correspondence = {key: key \
> - for key in self.card_type.fact_keys()}
> + self.correspondence = dict((key, key) for key in
> self.card_type.fact_keys())
> self.card_types_widget.setCurrentIndex(self.card_type_index)
> return
> else:
>
>
> --
> Tom Cato Amundsen <t...@gnu.org <mailto:t...@gnu.org>> http://www.solfege.org/
> GNU Solfege - free ear training http://www.gnu.org/software/solfege/
>
> --
> You received this message because you are subscribed to the Google
> Groups "mnemosyne-proj-users" group.
> To post to this group, send email to mnemosyne-...@googlegroups.com.
> To unsubscribe from this group, send email to
> mnemosyne-proj-u...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--
Peter Bienstman
Ghent University, Dept. of Information Technology
Sint-Pietersnieuwstraat 41, B-9000 Gent, Belgium
tel: +32 9 264 34 46, fax: +32 9 264 35 93
WWW: http://photonics.intec.UGent.be
email: Peter.B...@UGent.be

Tom Cato Amundsen

unread,
Nov 20, 2012, 3:48:07 PM11/20/12
to mnemosyne-...@googlegroups.com


On Tuesday, November 20, 2012 9:33:14 AM UTC+1, Peter Bienstman wrote:
Are you sure you are looking at the latest version from bzr?

No, I looked at 2.2 RC1, but I see now that it is in the bzr repo. Thanks!

Tom Cato

> mnemosyne-proj-users+unsub...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages