Re: [Macaulay2] Small typo in frobby version on M2 repo

[Daniel R. Grayson]

It's clearly a misprint, so I'll patch it. But I wonder why it
compiles for us on numerous versions of gcc. What version of what
compiler are you using?

On Sat, May 18, 2013 at 2:43 PM, Andrés Goens <and...@goens.org> wrote:
> Hi,
>
> I was trying to compile a M2 from the git repo (I took the one on
> https://github.com/Macaulay2/M2, but I guess since it gets downloaded it
> would happen with other ones as well). When compiling with --enable-download
> on the configure script, it would not build.
> It complained about a wrong type on line 143 of the file
> StatisticsStrategy.cpp on src/ of frobby, which read
> mpz_class q = mpq_class(_subGenSum) / _nodeCount;
>
> I assume it was a typo, and changing it to
>
> mpq_class q = mpq_class(_subGenSum) / _nodeCount;
>
> made everything compile. I thought it would be wise to post it here,
> especially since most of you I'd imagine have an already-built version of it
> and it makes it harder to spot like that.
>
> Regards,
>
> Andrés Goens
>
> --
> You received this message because you are subscribed to the Google Groups
> "Macaulay2" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to macaulay2+...@googlegroups.com.
> To post to this group, send email to maca...@googlegroups.com.
> Visit this group at http://groups.google.com/group/macaulay2?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[Thomas Kahle]

On 17:21 Sat 18 May 2013, Daniel R. Grayson wrote:
> It's clearly a misprint, so I'll patch it. But I wonder why it
> compiles for us on numerous versions of gcc. What version of what
> compiler are you using?

We also patched this in Gentoo. It happens with newer versions of
gmp/mpir because some implicit conversions have been removed.

Cheers,
Thomas

--
Thomas Kahle