Maybe leaking message with replacing Disruptor from 2.10.1 to 3.2.2 (with 3.3.2, too)

[임정택]

Hello.

I'm a newbie of Disruptor.

Currently Apache Storm uses Disruptor 2.10.1, and someone gave it a try to upgrade it to 3.2.2.

https://github.com/apache/storm/pull/134/files#diff-4cbcb6fa47274d6cf66d70585f98cbefR202

But when applying this we met failed tuples, and after reverting this failed tuples disappeared.

https://issues.apache.org/jira/browse/STORM-350

PR modifies only Disruptor related things, so it would be v2 vs v3 issue.

Since http://bad-concurrency.blogspot.kr/2013/04/release-of-disruptor-300.html shows that v3 beats v2 with single producer case, I really wish to adopt 3.x.

Are there bugs on PR? Or is it a Disruptor 3.x issue?

Am I have to re-implement disruptor.clj and DisruptorQueue.java to be compatible with 3.x?

Thanks in advance!

Regards.

Jungtaek Lim (HeartSaVioR)

[Michael Barker]

I'll have a look at it today, is there a specific test that show the issue?

Mike.

--
You received this message because you are subscribed to the Google Groups "Disruptor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to lmax-disrupto...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Michael Barker]

Is there are working version of storm?  I can't seem to get the main unit tests to pass.

[임정택]

Hello, Mike.

Sorry to respond too late.

No, unfortunately I don't have it since we found this issue from running benchmark to check topology's performance.

I'll give it a try.

Btw, doesn't modified code (I mean, PR) have defects? Is there a document which describes migration from 2.x to 3.x?

Thanks.

Regards.

Jungtaek Lim (HeartSaVioR)

2015년 3월 21일 토요일 오후 4시 27분 44초 UTC+9, mikeb01 님의 말: