Moving ledger-mode out of the main ledger repository

124 views
Skip to first unread message

John Wiegley

unread,
Aug 2, 2016, 5:21:16 PM8/2/16
to ledge...@googlegroups.com, Craig Earls
Hi guys,

Just wanted to let you know that I'll be splitting ledger-mode and the Emacs
code into its own repository within the ledger organization on GitHub soon.

If anyone has any concerns or issues, please let me know. The initial goal is
to reduce Travis activity due to frequent changes in ledger-mode, which can't
affect the Travis results.

John

Jacob MacDonald

unread,
Aug 2, 2016, 6:03:27 PM8/2/16
to ledge...@googlegroups.com, Craig Earls
Big fan of the change! I'll be on the lookout for it as I pull it myself instead of using MELPA.

--

---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Alexandre Rademaker

unread,
Aug 2, 2016, 6:30:40 PM8/2/16
to ledge...@googlegroups.com
1+ agree ! It makes sense!

Sent from my iPhone

Alexis

unread,
Aug 2, 2016, 6:50:24 PM8/2/16
to ledge...@googlegroups.com
Much in favor of this :)

Ben Finney

unread,
Aug 2, 2016, 7:03:46 PM8/2/16
to ledge...@googlegroups.com
"John Wiegley" <jwie...@gmail.com>
writes:

> Just wanted to let you know that I'll be splitting ledger-mode and the
> Emacs code into its own repository within the ledger organization on
> GitHub soon.

Are you de-coupling the release cycles, or will ‘ledger’ and
‘ledger-mode’ still track the same version and release at the same time?
How will that be managed?

--
\ “It is always a silly thing to give advice, but to give good |
`\ advice is absolutely fatal.” —Oscar Wilde, _The Portrait of Mr. |
_o__) W. H._, 1889-07 |
Ben Finney

John Wiegley

unread,
Aug 2, 2016, 7:29:11 PM8/2/16
to Ben Finney, ledge...@googlegroups.com
>>>>> "BF" == Ben Finney <bignose+h...@benfinney.id.au> writes:

BF> Are you de-coupling the release cycles, or will ‘ledger’ and
BF> ‘ledger-mode’ still track the same version and release at the same time?
BF> How will that be managed?

They don't need to be exactly synced, unless there is a change in the data
protocol used between them, or in the reporting arguments. But all of that is
very stable now.

--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2

Craig Earls

unread,
Aug 2, 2016, 7:30:12 PM8/2/16
to ledge...@googlegroups.com
Works for me. As far as synchronizing releases there isnt much necessary. Unless the interface changes ledger-mode is happy with 3.x version. 
--

---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
Craig, Corona De Tucson, AZ
enderw88.wordpress.com

Craig Earls

unread,
Aug 2, 2016, 7:30:54 PM8/2/16
to ledge...@googlegroups.com
Works for me. As far as synchronizing releases there isnt much necessary. Unless the interface changes ledger node is happy with 3.x version. 


On Tuesday, August 2, 2016, Ben Finney <bignose+h...@benfinney.id.au> wrote:
"John Wiegley" <jwie...@gmail.com>
writes:

> Just wanted to let you know that I'll be splitting ledger-mode and the
> Emacs code into its own repository within the ledger organization on
> GitHub soon.

Are you de-coupling the release cycles, or will ‘ledger’ and
‘ledger-mode’ still track the same version and release at the same time?
How will that be managed?

--
 \        “It is always a silly thing to give advice, but to give good |
  `\   advice is absolutely fatal.” —Oscar Wilde, _The Portrait of Mr. |
_o__)                                                  W. H._, 1889-07 |
Ben Finney

--

---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

John Wiegley

unread,
Aug 2, 2016, 8:12:07 PM8/2/16
to Craig Earls, ledge...@googlegroups.com
>>>>> "CE" == Craig Earls <ende...@gmail.com> writes:

CE> Works for me. As far as synchronizing releases there isnt much necessary.
CE> Unless the interface changes ledger-mode is happy with 3.x version.

Ok, we now have a new repository under the Ledger organization:

https://github.com/ledger/ledger-mode

I have also remove the lisp/ directory from the ledger project, although I
have a feeling CMake is going to need to be told too...

Ben Finney

unread,
Aug 2, 2016, 8:14:12 PM8/2/16
to ledge...@googlegroups.com
"John Wiegley" <jo...@newartisans.com> writes:

> >>>>> "BF" == Ben Finney <bignose+h...@benfinney.id.au> writes:
>
> BF> Are you de-coupling the release cycles, or will ‘ledger’ and
> BF> ‘ledger-mode’ still track the same version and release at the same
> BF> time? How will that be managed?
>
> They don't need to be exactly synced

So, my question was based on the assumption that until now they are both
on a single release cycle, and both have an identical version at all
times. Is that assumption correct?

> unless there is a change in the data protocol used between them, or in
> the reporting arguments. But all of that is very stable now.

When the split occurs, will the versions mean what they do today by
remaining in lock-step at each release? Or will they diverge?

--
\ “Everyone is entitled to their own opinions, but they are not |
`\ entitled to their own facts.” —US Senator Pat Moynihan |
_o__) |
Ben Finney

John Wiegley

unread,
Aug 2, 2016, 8:15:35 PM8/2/16
to Ben Finney, ledge...@googlegroups.com
>>>>> "BF" == Ben Finney <bignose+h...@benfinney.id.au> writes:

BF> So, my question was based on the assumption that until now they are both
BF> on a single release cycle, and both have an identical version at all
BF> times. Is that assumption correct?

Yes, they were part of the same source code before. There was only one
release, of both.

BF> When the split occurs, will the versions mean what they do today by
BF> remaining in lock-step at each release? Or will they diverge?

They can diverge freely.

Craig Earls

unread,
Aug 2, 2016, 8:18:05 PM8/2/16
to ledge...@googlegroups.com
I will use a separate version number. Up to this point there hasnt been one they are very loosely coupled. I am open to suggestions.   Ledger mode is mostly getting bug fixes no features have been added in a few years now. 


On Tuesday, August 2, 2016, Ben Finney <bignose+h...@benfinney.id.au> wrote:
--

---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

David Glasser

unread,
Aug 2, 2016, 8:21:15 PM8/2/16
to ledge...@googlegroups.com
Having a tight coupling between ledger and ledger-mode versions would have been a problem even when they were in the same repo, since there's not much to encourage users to make sure to carefully upgrade them simultaneously.

Jacob MacDonald

unread,
Aug 2, 2016, 8:28:05 PM8/2/16
to ledge...@googlegroups.com
I would suggest just using semver, treating a bump of the required Ledger version as a breaking change and noting the minimum required Ledger version in the release notes. I'm saying this with no knowledge of whether Ledger likes semver or has a problem with unsynchronized version numbers/large major versions :-).

Simon Michael

unread,
Aug 4, 2016, 2:10:51 PM8/4/16
to ledge...@googlegroups.com
This is great. It will be clearer what's happening in each project. It's
also nice that ledger-mode's commit history was preserved.

Craig, how about moving ledger-mode issue tracking to github ? This
seems like a great time.

Jacob MacDonald

unread,
Aug 4, 2016, 3:10:44 PM8/4/16
to ledge...@googlegroups.com
Submitting a quick PR to MELPA here: https://github.com/melpa/melpa/pull/4099, unless @purcell is watching this mailing list?

Craig Earls

unread,
Aug 4, 2016, 3:15:22 PM8/4/16
to ledge...@googlegroups.com
I agree. I will work this this weekend. 


On Thursday, August 4, 2016, Simon Michael <si...@joyful.com> wrote:
This is great. It will be clearer what's happening in each project. It's also nice that ledger-mode's commit history was preserved.

Craig, how about moving ledger-mode issue tracking to github ? This seems like a great time.

--

--- You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Alexis

unread,
Aug 4, 2016, 5:46:49 PM8/4/16
to ledge...@googlegroups.com
Hi John,

can you include the doc/ledger-mode.texi file in the ledger-mode repo
also? I think it makes sense to move the documentation to the sources.


Cheers
Alexis

John Wiegley

unread,
Aug 5, 2016, 12:18:41 AM8/5/16
to Alexis, ledge...@googlegroups.com
>>>>> "A" == Alexis <surr...@gmail.com> writes:

A> can you include the doc/ledger-mode.texi file in the ledger-mode repo
A> also? I think it makes sense to move the documentation to the sources.

Done, complete with the history for that file along the second merge parent.

thierry

unread,
Sep 21, 2016, 3:41:09 AM9/21/16
to Ledger, jo...@newartisans.com
Hi John and all,

One year that I have not posted here, very busy at work, and girlfriend has come in life...

I do not know what went wrong, but I am unable to browse the history of the *content* of the commits of ledger-mode.texi. Either via github, or via magit, I can see the *header* (date, commit message) of the commit, but I am unable to browse the content of the commit, that is what was actually changed by the commit. Is is something that can be restored ?

Thanks
Thierry

John Wiegley

unread,
Sep 22, 2016, 10:12:28 AM9/22/16
to thierry, Ledger
>>>>> thierry <th...@free.fr> writes:

> I do not know what went wrong, but I am unable to browse the history of the
> *content* of the commits of ledger-mode.texi. Either via github, or via
> magit, I can see the *header* (date, commit message) of the commit, but I am
> unable to browse the content of the commit, that is what was actually
> changed by the commit. Is is something that can be restored ?

I see contents for some of the commits, for example:

https://github.com/ledger/ledger-mode/commit/440de1d9acf8080f5d690f8581139c635c58fa9b

This history was produced by git-subtree, so it's possible some of them may
have ended up empty. I forgot to squeeze out empty commits after the
extraction had completed.

John
Reply all
Reply to author
Forward
0 new messages