Replacing submit-queue with tide for kubernetes/community

95 views
Skip to first unread message

Aaron Crickenberger

unread,
Dec 19, 2017, 5:46:59 PM12/19/17
to Kubernetes developer/contributor discussion
tl;dr as a contributor you should see no difference in the workflow you use to contribute, review, and approve PR's for the kubernetes/community repo

Tide [1] is a thing SIG Testing been working on to replace the submit-queue [2].  It uses github queries instead of webhooks to select pools of PR's instead of an ordered queue of PR's.  For more information on why, see the proposal / design doc [3].

We've been using tide against kubernetes/test-infra for ~three months, kubernetes/federation for ~two months, and recently enabled it for (among other repos) kubernetes/kubectl and kubernetes/charts.  As I mentioned during SIG Testing's Oct 19 update to the community [4], our goal is to replace the submit-queue for all kubernetes repos.

I would like to do this tomorrow for kubernetes/community [5]

I'm e-mailing kubernetes-dev about this to give you a heads up that this is happening.  We recognize tide needs docs [6] and could stand to use a nicer UI before we enable tide on a highly-tested, high-traffic repo like kubernetes/kubernetes.  Turning on tide for kubernetes/community will expose it to a larger audience to help get us there.

Questions and feedback welcome.

- aaron

Clayton Coleman

unread,
Dec 19, 2017, 5:51:11 PM12/19/17
to Aaron Crickenberger, Kubernetes developer/contributor discussion
Tide is awesome, I’m glad to see it continues to get better and better!  Thanks for all the hard work from the entire sig-testing team.
--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-de...@googlegroups.com.
To post to this group, send email to kuberne...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/9dc903ba-a980-48e6-aa52-a86cf3d81892%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Aaron Crickenberger

unread,
Dec 20, 2017, 4:38:58 PM12/20/17
to Kubernetes developer/contributor discussion
This is now done.

Congrats @alpha-san and @cblecker, https://github.com/kubernetes/community/pull/1532 wins the award for first kubernetes/community PR to be merged by tide!

- aaron

Michail Kargakis

unread,
Dec 22, 2017, 1:47:19 PM12/22/17
to Aaron Crickenberger, Kubernetes developer/contributor discussion
We also use it in a bunch of Openshift repos and it works great so far.

Aaron Crickenberger

unread,
Jan 4, 2018, 7:06:31 PM1/4/18
to Kubernetes developer/contributor discussion
Hi all,

Brief update on where we're at with tide now:

- we're now using tide to handle 11 repos in github.com/kubernetes
- kubernetes/kubernetes is the only remaining repo to use submit-queue
- tide's UI is looking much nicer, thanks @BenTheElder! https://prow.k8s.io/tide.html
- @spxtr will be updating tide to set a more user-friendly status context on PR's: https://github.com/kubernetes/test-infra/issues/6145

- aaron
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages