dSFMT patches

[Milan Bouchet-Valat]

Hi!

I wonder what's the status of the dSFMT patches in deps/. I'm asking
because I have to use a system dSFMT library for the Fedora package.
Thus, the dSFMT Fedora package needs to apply the same patches as those
in Julia; this obviously can only happen if they are considered good
enough to be made public.

I've noticed in particular that several static methods are changed to be
exported by the patch. But there was probably a reason why they were
private in the upstream code. Are there any risks associated with their
use?

(The other patch, replacing uses of int with ptrdiff_t looks easier to
get included.)

Thanks!

[Viral Shah]

The patches are only there because DSFMT by default expects to be compiled inline, and not be used as a shared library. If there is already a shared library, the patch should not be required. It basically changes `static inline` to `extern`.

-viral

[Milan Bouchet-Valat]

Le samedi 21 juin 2014 à 22:20 -0700, Viral Shah a écrit :
> The patches are only there because DSFMT by default expects to be
> compiled inline, and not be used as a shared library. If there is
> already a shared library, the patch should not be required. It
> basically changes `static inline` to `extern`.

Thanks. So it is probably already applied to the package in one way or
another. I'll have a look.


Regards