FYI. Bug in com_users/controllers/reset.php

[Caleb]

Line 76 in com_users/controllers/reset.php..  

			$this->setRedirect(JRoute::_($route, false), $message);

In the case of reset success, it tries to use variable $message without ever defining a message, causing a PHP error to be logged.

This is actually the same as tracker bug

   [#25423] $message not initialized in ~/components/com_users/controllers/reset.php

from a year or so ago. #25423 was closed without a fix as "not in Joomla core" because someone mentioned unrelated component com_accounts in the incident. But it is actually a core com_users issue.

I see this problem on 1.7.3, and I just verified that it is still a problem in latest 2.5 code.

[Matt Thomas]

That tracker item has been re-opened based on your report - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=25423

Thanks!

Best,

Matt Thomas

Founder betweenbrain™

Lead Developer Construct Template Development Framework

Phone: 203.632.9322
Twitter: @betweenbrain

Github: https://github.com/betweenbrain

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/V8t9kzuemXgJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.

[Caleb]

Thanks. Tiny issue, but testing secure registration/login/reset for a new component, PHP started yelling at me about this one..

[Matt Thomas]

Thank you for following it up. If you have a chance to submit a patch or pull request to fix it, that'd be great.

Best,

Matt Thomas

Founder betweenbrain™

Lead Developer Construct Template Development Framework

Phone: 203.632.9322
Twitter: @betweenbrain

Github: https://github.com/betweenbrain

On Mon, Jan 23, 2012 at 7:15 PM, Caleb <d...@emeum.com> wrote:

Thanks. Tiny issue, but testing secure registration/login/reset for a new component, PHP started yelling at me about this one..

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.

To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/9jPAUOBay9AJ.