Groups don't work on tab completion

[Brad Wood]

I'm breaking this off into its own thread.  Here is the repro case for my issues with the "group" in tab completion candidates.  You never said how group was supposed to behave, but what I'm seeing certainly doesn't make much sense.  

Here's how to run the code:

• Grab CommandBox CLI.  It's a binary that will run CFML code, a JVM language that CommandBox is written in.  (CommandBox is the app where I use Jline!)  You'll need the 4.0.0-snapshot build, which has JLine3 bundled
  http://integration.stg.ortussolutions.com/artifacts/ortussolutions/commandbox/4.0.0-SNAPSHOT/
  If you're on Windows, grab  commandbox-win-4.0.0-SNAPSHOT.zip and if you're on *nix, grab  commandbox-bin-4.0.0-SNAPSHOT.zip
• Save the two attached files and place them in a directory
  
• test.cfm is a script that creates JLine and generates a prompt
• completor.cfc is my completor class
• Run the test.cfm file like so:
  box test.cfm
• When the prompt appears, hit the "tab" key.  

If you look at the completor, you'll see it is very simple and just adds 4 candidates.  Two of them have a group of "group1" and the other two have a group of "group2". Here is the output I see when I hit tab:

CommandBox> option_

group2

group1

option1   option2   option3   option4

The words "group1" and "group2" appear but they're just stuck up at the top and the actual candidates aren't grouped under their respective groups.  

If you want to play with CommandBox proper, just run box with no arguments and you'll get the normal shell.

Thanks!

~Brad

Developer Advocate

Ortus Solutions, Corp 

E-mail: br...@coldbox.org

ColdBox Platform: http://www.coldbox.org 

Blog: http://www.codersrevolution.com

[Brad Wood]

Let me know if I should create a ticket for this.

Thanks!

~Brad

[Guillaume Nodet]

Yes please. It definitely looks like a bug.

--
You received this message because you are subscribed to the Google Groups "jline-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jline-users...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Brad Wood]

https://github.com/jline/jline3/issues/200

[Brad Wood]

I saw that you completed the ticket so I gave it another test today.  I added a 5th option to my test as well in that had null for a group.

This is an improvement for sure.  I have a few questions though.

• What is the default ordering of the groups and can I change it?  
• It seems like "others" should probably be at the bottom under the grouped candidates, not in the middle.
• What do you think about some spacing or indention or something to help separate the group names from the candidates?
• Can we change up the colors? Right now the "match what has been typed" color is the same as the group name color. Look at this screenshot:

I've started typing the word "option" which matches the first part of all shown candidates but their color is the same as the group name colors so it all just sort of blend together.  Maybe we can make the group names bold, or another color entirely.

Thanks!

~Brad

[Brad Wood]

Any feedback on my completion suggestions?

Thanks!

~Brad

[Guillaume Nodet]

Please raise issues when you'd like something to be addressed : the mailing list is fine for discussing things, but not so good to track them.

The colors are hard-coded:

   https://github.com/jline/jline3/blob/master/reader/src/main/java/org/jline/reader/impl/LineReaderImpl.java#L4499

   https://github.com/jline/jline3/blob/master/reader/src/main/java/org/jline/reader/impl/LineReaderImpl.java#L4564

The styling and sorting could definitely be made configurable somehow.

--
You received this message because you are subscribed to the Google Groups "jline-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jline-users+unsubscribe@googlegroups.com.

[Brad Wood]

Yes, I'm fine raising issues, but I wanted to see what was already implemented that I didn't know about.  Since there's no completion docs, I didn't want to make assumptions.

I boiled my feedback down to two main tickets:

https://github.com/jline/jline3/issues/210
https://github.com/jline/jline3/issues/211

Thanks!

~Brad

Developer Advocate

Ortus Solutions, Corp 

E-mail: br...@coldbox.org

ColdBox Platform: http://www.coldbox.org 

Blog: http://www.codersrevolution.com