Samples with warnings

[Rob Hamerling]

Hi Matt and Seb,

Matt: May I ask you to have a look at your servo_slave samples?? The PWM
libraries have been changed lately and now several of these samples
produce warnings like:

> x:\lib/pwm_ccp1.jal:125: warning: "pwm1_set_dutycycle() is deprecated,
> .. use pwm1_set_dutycycle_percent() or pwm1_set_dutycycle_ratio()"
> x:\lib/pwm_ccp2.jal:125: warning: "pwm2_set_dutycycle() is deprecated,
> .. use pwm2_set_dutycycle_percent() or pwm2_set_dutycycle_ratio()"

It concerns the following samples:

16f877a_servo_rc_slave
16f877_servo_rc_slave
18f4525_servo_rc_slave
18f452_servo_rc_slave
18f4550_servo_rc_slave
18f4620_servo_rc_slave

This is because of changes in the dutycycle setting procedures.


And Seb: with the new compiler (2.4p) there is a sample of yours giving
a warning:

> 18f27j53_sd_card_minix_read.jal:154: warning: fewer initializers than expected

Maybe you can find a way to suppress this warning.

Regards, Rob.


--
R. Hamerling, Netherlands --- http://www.robh.nl

[Sebastien Lelong]

Hi Rob,

About Minix sample, this is due to bug (probably) in compiler. You already reported this, Kyle had to have a look. Here's my reply at that time, for the record:

"""

About the sample, I had a look, it seems like a bug in the compiler. Guilty line:

const byte myfile[MINIX_MAX_FILENANE_LEN] = "file2K\0                       "

This is a NULL terminated string. MINIX_MAX_FILENAME_LEN is const, its value is 30.

Now replace "\0" by "\n", warning is gone. Sounds like the compiler doesn't like \0 escape sequence...

"""

Cheers,

Seb

--
You received this message because you are subscribed to the Google Groups "jallib" group.
To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Rob Hamerling]

Hi Seb,

On 9-12-12 10:10, Sebastien Lelong wrote:

> About Minix sample, this is due to bug (probably) in compiler. You
> already reported this, Kyle had to have a look.

You are right! Sorry, degradation of my short-term memory :-(

[mattschinkel]

Sorry guys... I just moved into a new house so my PC and electronics are all in a box. Can someone please update my lib?

 

I also haven't been able to read all the messages here so I'm not sure why pwm1_set_dutycycle was deprecated.

[Rob Hamerling]

Hi Matt,

Congratulations with your new house! Hope you'll be settled soon.

I changed the PWM libraries in an attempt to make their use more
intuitive, especially the setting of the duty cycle. It is not very
productive to repeat here what is in the library comments...
I can try to convert your samples. The required changes are not
complicated and I don't expect these will result in not working samples,
but I cannot test 'm. We can discuss the changes (both in the libraries
and the samples) when you're back.

[mattschinkel]

Hi Rob,

Go ahead and make the changes if you are comfortable that it will work without testing.