JaCoCo Build broken since removal of Pack200

[Marc Hoffmann]

Hi Evgeny,

the removal of Pack200 has been merged into JDK today. This breaks our build on JDK HEAD:

https://pici.beachhub.io/#/jdk-jacoco/20191210-020137

What should we do about it?

1) Remove Pack200 support

2) Implement optional Pack200 support with reflection

3) Other ideas?

To keep thinks simple I would go with option 1.

Regards,

-marc

[Evgeny Mandrikov]

On Tuesday, December 10, 2019 at 8:37:48 AM UTC+1, Marc R. Hoffmann wrote:

Hi Evgeny,

the removal of Pack200 has been merged into JDK today. This breaks our build on JDK HEAD:

https://pici.beachhub.io/#/jdk-jacoco/20191210-020137

Hi Marc,

Yes - I saw this change ( http://hg.openjdk.java.net/jdk/jdk/rev/f236fd5d0c2c ) and believe that it will be part of upcoming Early Access build 27.

 

What should we do about it?

1) Remove Pack200 support

2) Implement optional Pack200 support with reflection

3) Other ideas?

To keep thinks simple I would go with option 1.

Since appearance of JEP ( https://openjdk.java.net/jeps/367 ) I was thinking about option 2 with a clear message for JDKs without pack200 support.

As a note addition of support for Pack200 originates from EclEmma - see https://github.com/jacoco/jacoco/pull/91 and https://github.com/jacoco/eclemma/issues/49

I'm wondering which pros and cons beside simplicity of removal you see in these options?

Regards,

Evgeny

[Marc Hoffmann]

Ok, then let’s option 2 give a try!

I can work on it this Friday.

--
You received this message because you are subscribed to the Google Groups "JaCoCo Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jacoco-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jacoco-dev/ea90cd3f-417b-40a8-8d7a-665573eed99a%40googlegroups.com.

[Evgeny Mandrikov]

On Tue 10 Dec 2019 at 22:45, Marc Hoffmann <hoff...@mountainminds.com> wrote:

Ok, then let’s option 2 give a try!

I can work on it this Friday.

I already tried today ;) will push tomorrow 

To view this discussion on the web visit https://groups.google.com/d/msgid/jacoco-dev/0661B291-DFA9-4FCE-89E1-98339EF4300A%40mountainminds.com.

--

Regards,

Evgeny