Issue with account combinations - always ask if a new account combination should be created

[Nicolas Micoud]

Hi,

Steps to reproduce :

open BPartner / Customer Accounting :

 on Customer Receivables, create a new combination (eg *-21510) and use it.
 
 Then, on Customer Prepayment, open the dialog box and select same values (Org=* and Account=21510).
 When clicking on OK button, a popup will ask if we want to create a new combination. It shouldn't as it already exists.
 In this case, it should only close the dialog box and update the content of the Customer Prepayment field.
 
 
 Not sure about the best way to deal with it.
 
 Maybe add a check on the : onEvent / ok part ; something like that :
 

 if (needconfirm) {
 
    // Check if the combination already exists (see action_Save ; where comment is "Check if already exists")
    // if (MAccount.get(<all dimensions from dialog>) == null {
   
        FDialog.ask(m_WindowNo, this, "CreateNewAccountCombination?", new Callback<Boolean>() {
       
        }

    }
 }

  It would need to create a new method 'exists' which will be used in action_Save and here.
 
 WDYT ?

Nicolas

[Carlos Antonio Ruiz Gomez]

Hi Nicolas, are you using the new preference "Use Similar To" instead of LIKE?

Testing your scenario I just found a bug there - using LIKE seems to work without problem.

Regards,

Carlos Ruiz

[Nicolas Micoud]

Hi Carlos,

I reproduce it on test.idempiere.org this morning (before your commit) and on my instance (Oracle), i use an idempiere version of november 2017 (before integration of https://idempiere.atlassian.net/browse/IDEMPIERE-1906).
Bug is still on test.idempiere.org (see attached screenshots) :

 - 1 : window





 - 2 : dialog open and udpate account (13100 to 21510), then click on save - it should not as the combination already exists




Or I miss something ?

[Carlos Antonio Ruiz Gomez]

I just committed a fix, is not still on the test servers.
https://bitbucket.org/idempiere/idempiere/commits/b8352a6

Tested on postgresql

Am 02.05.2018 um 13:42 schrieb Nicolas Micoud:

Hi Carlos,

I reproduce it on test.idempiere.org this morning (before your commit) and on my instance (Oracle), i use an idempiere version of november 2017 (before integration of https://idempiere.atlassian.net/browse/IDEMPIERE-1906).
Bug is still on test.idempiere.org (see attached screenshots) :

 - 1 : window

 - 2 : dialog open and udpate account (13100 to 21510), then click on save - it should not as the combination already exists

[Nicolas Micoud]

AFAIU, the patch will fix postgresql, but not Oracle, right ?

[Carlos Antonio Ruiz Gomez]

I don't know - I don't have oracle local to test.

[Nicolas Micoud]

I will check but issue is still there on the WAccountDialog.

(your patch "only" improve the search before dialog box opens)

Eg: if you make a mistake when writing the Alias or the combination, the dialog will open and there, if you set correct Org and account, it will still ask is it should create new combination

[Nicolas Micoud]

I can't remember the logic we use when implementing this :-/

We check values from dialog box with combination from the field of the tab (combiOrg).
If there at least one difference, we ask if we need to create a new combination.

Whereas if user has selected values from an already existing combination, then we should use it directly, without prompting anything.

[Carlos Antonio Ruiz Gómez]

xref https://www.globalqss.com/idempiere/irclog/%23idempiere.2018-05-02.log.html#t2018-05-02T13:54:04