PSA: Gyp code review switching to Gerrit

20 views
Skip to first unread message

Aaron Gable

unread,
Jan 20, 2017, 5:38:48 PM1/20/17
to gyp-developer, Sylvain Defresne, Andrew Bonventre

Hey gyp devs,


As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.


As part of that process, on Tuesday, Jan 24th, we're switching gyp to use Gerrit for code review by default.


In preparation for this change, please:

1) navigate to Gerrit and sign in to ensure you have an account; and

2) make sure that you are using the newer Polymer-base PolyGerrit UI by clicking the link in the footer of any page.


This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.


You can follow the progress of the switch in the tracking bug here.


Thanks,

Aaron


Dirk Pranke

unread,
Jan 20, 2017, 7:01:42 PM1/20/17
to Aaron Gable, gyp-developer, Sylvain Defresne, Andrew Bonventre
Sounds good to me. GYP is very quiet, so feel free to switch whenever and we'll deal.

-- Dirk

On Fri, Jan 20, 2017 at 2:38 PM, Aaron Gable <aga...@chromium.org> wrote:

Hey gyp devs,


As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.


As part of that process, on Tuesday, Jan 24th, we're switching gyp to use Gerrit for code review by default.


In preparation for this change, please:

1) navigate to Gerrit and sign in to ensure you have an account; and

2) make sure that you are using the newer Polymer-base PolyGerrit UI by clicking the link in the footer of any page.


This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infra+polygerrit@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.


You can follow the progress of the switch in the tracking bug here.


Thanks,

Aaron


--

---
You received this message because you are subscribed to the Google Groups "gyp-developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gyp-developer+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Aaron Gable

unread,
Jan 24, 2017, 2:20:05 PM1/24/17
to gyp-developer, aga...@chromium.org, sdef...@chromium.org, andy...@chromium.org
All the relevant changes have been made! Once you've synced your local checkout to tip of tree, your next CL will upload to Gerrit.

Thanks, everybody!
Aaron
Reply all
Reply to author
Forward
0 new messages