gRFC L22: Change name of directory `include/grpc++` to `include/grpcxx`

[Muxi Yan]

grpc.io members,

Please review gRFC proposal L22 which proposes changing the header directory of gRPC C++ library from `include/grpc++` to `include/grpcxx` for compatibility issue. Let me know any question, comment, or concern.

[Srini Polavarapu]

Is the reason for choosing grpcxx (vs grpc_cpp or grpc_plusplus) is so that it is inline with #ifndef GRPCXX_AAA_BBB_H usage in header files?

[Mark D. Roth]

I would prefer to see us use "grpcpp" instead of "grpcxx", for consistency with the naming convention used in the src tree (e.g., src/cpp and src/lib/gprpp).

On Thu, Jan 25, 2018 at 4:44 PM, 'Muxi Yan' via grpc.io <grp...@googlegroups.com> wrote:

grpc.io members,

Please review gRFC proposal L22 which proposes changing the header directory of gRPC C++ library from `include/grpc++` to `include/grpcxx` for compatibility issue. Let me know any question, comment, or concern.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscribe@googlegroups.com.
To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/24b588ac-8eef-4732-86d5-0a5bdb452813%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Mark D. Roth <ro...@google.com>
Software Engineer
Google, Inc.

[Muxi Yan]

I picked `cxx` since I saw it before somewhere in gRPC code base and I thought that was a more common alias. But as Mark said, we are already using `cpp` in our current directory structure so I am totally good with `grpcpp`.

[Vijay Pai]

Are dashes allowed in your names? Can I suggest instead "grpc-cpp" or "grpc-cxx" ? The multiplexing of "c" to mean "call" and also "the C programming language" has always bothered me. This also makes it clear that C++ is one among many gRPC languages (like grpc-java, grpc-go, grpc-swift, grpc-node repo names), not the "natural" choice.

[falco...@gmail.com]

Thanks for this change. Looking forward to it. Had severe problems building the code base with the embarcadero bcc32 toolset. Especially the library manager tlib has problems with + and - in the filenames. So right now, I already had to patch the ninja build files to use grpcpp_unsecure.lib instead of grpc++_unsecure.lib. Since - is also a special char, I would prefer grpc_cpp or grpc_cxx.

BCC32 is a clang-enhanced c++ compiler and therefore has similar problems as the iOS compiler. Beside the naming, I also just had to add some more macros to get it compiled and fully supported.

[Muxi Yan]

@falco... - Thanks for the feedback

@Vijay - dash does not work. As mentioned in the gRFC, the framework must be a valid C99 extended identifier. Underscore works; but I think it would be a good idea to come up with a common name that is followed throughout the entire repository. For that, I think grpcpp works better for now. However I kind of agree with you that grpcpp is a bit bothering.