Move gwt-traction to GitHub?

88 views
Skip to first unread message

Andy

unread,
Nov 21, 2012, 10:21:48 AM11/21/12
to google-we...@googlegroups.com
I'm thinking about moving our little library to GitHub and was wondering if anyone had an opinion.


1. Do you think I should?

2. If you were going to contribute a feature or bugfix, would you be more likely to do so on GitHub?

3. Do you think I should break it into a bunch of small projects or keep it in one jar? Most of the widgets are completely independent from each other.

I've been considering it for a while and recently noticed that gwt-test-utils and a few other projects have moved.

Thanks for your feedback,
Andy

Thomas Broyer

unread,
Nov 21, 2012, 10:36:27 AM11/21/12
to google-we...@googlegroups.com


On Wednesday, November 21, 2012 4:21:48 PM UTC+1, Andy wrote:
I'm thinking about moving our little library to GitHub and was wondering if anyone had an opinion.


1. Do you think I should?

I'm not using your lib, so I can't comment here. As a consequence, do not give much weight to my comments below.
 
2. If you were going to contribute a feature or bugfix, would you be more likely to do so on GitHub?

This applies to any project: if you're not using a good code-review tool (Gerrit or Rietveld –e.g. codereview.appspot.com, Rietveld works best with Git and the git-cl script from repo-tools though–, there are probably others; I don't consider ReviewBoard a good tool, though it's still better than nothing), then yes, definitely: Pull Requests *are* a good code-review tool.

3. Do you think I should break it into a bunch of small projects or keep it in one jar? Most of the widgets are completely independent from each other.

We're about to break gwt-user into smaller JARs, but it'll still be one big repo (because we'll release all those JARs as a whole). We're still discussing the level of granularity though.
From the widgets/features advertized on your home page, I think I'd keep it as a single project and a single JAR. Maybe the AutoSizingTextArea could be split apart, because of its dependency on gwt-query; that doesn't mean it should be in a distinct repo though; depends what you release policy is.

Andy

unread,
Nov 21, 2012, 11:20:38 AM11/21/12
to google-we...@googlegroups.com
I appreciate the feedback and it's interesting to hear that you're splitting up gwt-user.

I'll probably keep most of it together, but RawHistory probably belongs in its own repo. As you mentioned AutoSizingTextArea could be on its own. It will be a great day when I can add a deferred binding rule for browsers that support auto-sizing textareas natively.

Ümit Seren

unread,
Nov 22, 2012, 10:49:06 AM11/22/12
to google-we...@googlegroups.com


On Wednesday, November 21, 2012 4:21:48 PM UTC+1, Andy wrote:
I'm thinking about moving our little library to GitHub and was wondering if anyone had an opinion.


1. Do you think I should?

I moved most of my stuff over to github. I somehow like the interface more then google code. 
 
 
2. If you were going to contribute a feature or bugfix, would you be more likely to do so on GitHub?


Pull requests on github are a very neat feature. It's relatively easy to use them, so IMHO they facilitate contributions by third parties. 
I myself opened some pull requests for an open source projects where I fixed a bug and it was a breeze.
Reply all
Reply to author
Forward
0 new messages