RequestFactoryServlet config and symbolMapsDirectory

73 views
Skip to first unread message

Stephen Buergler

unread,
Jan 22, 2012, 11:52:05 AM1/22/12
to google-we...@googlegroups.com
Shouldn't the stuff in com.google.web.bindery.requestfactory.server.RequestFactoryServlet.ensureConfig() be in init() instead so you don't have to call it for every POST? Also is there a reason it doesn't default to looking for the symbolMapsDirectory wherever gwt normally puts them by default?

Thomas Broyer

unread,
Jan 22, 2012, 3:37:59 PM1/22/12
to google-we...@googlegroups.com


On Sunday, January 22, 2012 5:52:05 PM UTC+1, Stephen Buergler wrote:
Shouldn't the stuff in com.google.web.bindery.requestfactory.server.RequestFactoryServlet.ensureConfig() be in init() instead so you don't have to call it for every POST?

It seems like it could. Feel free to contribute the patch: http://code.google.com/webtoolkit/makinggwtbetter.html#contributingcode
 
Also is there a reason it doesn't default to looking for the symbolMapsDirectory wherever gwt normally puts them by default?

Because (only guesses):
 - AFAICT, StackTraceDeobfuscator works off java.io.File and in most cases apps will run off WARs
 - people can choose to output somewhere else (pass -deploy to the compiler) or simply move/not deploy the folder
 - deobfuscation takes time, so it's off by default
Reply all
Reply to author
Forward
0 new messages