Struggling to set up sharing Infowindow link with a unique url inside its own infowindow?

154 views
Skip to first unread message

Christopher Watson

unread,
Oct 30, 2011, 6:29:44 PM10/30/11
to google-map...@googlegroups.com
Ok, 

always seem to try, what seems to be, complicated stuff. 


What I am after is putting www.sharethis.com widget inside every infowindow. There might be lots of stuff i'm assuming can happen, and there is probably a much easier route then as comlex as i approach but, here goes. 


Cool, generates a unique url. I tried to 'fit' it in around my testing page here: http://creativemaps.vism.ag/indexinfowindowurl.htm

Now I load markers from an xml and I put it inside: 

<Placemark>
    <name>Natural History Museum of Los Angeles County</name>
    <description><![CDATA[


<script type="text/javascript" src="http://w.sharethis.com/button/buttons.js"></script><script type="text/javascript">stLight.options({publisher:'32e78673-44d5-48be-8e1c-9578aa7393cf'});</script>
<script src="http://platform.twitter.com/widgets.js" type="text/javascript"></script>

<style type="text/css" media="screen">
  #custom-tweet-button a {
"entities" : {
    "urls" : [
      {
        "display_url" : "<input type="text" id="markerbox" style="width:400px"></input>", 
        }
    ], 
    ...
  }, 
  }
</style>

<div id="custom-tweet-button">
  <a href="http://twitter.com/share" class="twitter-share-button"
     data-url="<a href="javascript:myclick(' + (gmarkers.length-1) + ')">' + name + '<\/a>"
     data-counturl="<a href="javascript:myclick(' + (gmarkers.length-1) + ')">' + name + '<\/a>"
     data-count="vertical"
     data-via="visualthinkmap">Tweet</a>     
</div><td/><td>


<span class="st_facebook_vcount" st_url="<a href="javascript:myclick(' + (gmarkers.length-1) + ')">' + name + '<\/a>" displayText="Share"></span>
<span class="st_email_vcount" st_url="<a href="javascript:myclick(' + (gmarkers.length-1) + ')">' + name + '<\/a>" displayText="Email"></span>
<span class="st_sharethis_vcount" st_url="<a href="javascript:myclick(' + (gmarkers.length-1) + ')">' + name + '<\/a>" displayText="Share"></span></td></tr>

</TABLE>
<br>

]]>






</description>
<address>900 Exposition Boulevard
Los Angeles, CA 90007, United States
(213) 763-3466</address>
    <styleUrl>#Museums and Galleries</styleUrl>
    <Point>
      <coordinates>-118.288795,34.017284,0.000000</coordinates>
    </Point>
  </Placemark>



Now I assume I can use javascript inside the infowindow, the bold underlined part is from my site as this displays the unique url to the infowindow, i want to pull the url into the sharethis.


As I say its probably a redundant way to do what i wanted to make a unique url for infowindow. 

I used the share this on my blog and it pulls the unique url from php, how can i put the share this into the info window and it detect the url generated from xelawho link?

btw, didnt need a sidebar as with the xelawho link but thought function myclick(i) would still work as a marker has to be clicked.


If you have an easier way with the code that i already have i'll try that.

any help greatly appreciated as always. 

ps been testing to put it inside Natural History Museum of Los Angeles County (had to zoom out slightly to see it).

Joseph Elfelt

unread,
Oct 31, 2011, 1:19:18 PM10/31/11
to Google Maps JavaScript API v3
Question: Can javascript be used in an infowindow?

From a PM I traded with Google staff the answer is: yes and no.

Yes - if you are building the infowindow yourself with API calls.

No - if you are displaying a KML/KMZ file.

Christopher Watson

unread,
Nov 1, 2011, 8:45:50 AM11/1/11
to google-map...@googlegroups.com
hey joseph, 

does loading an xml fall into a kml/kmz category?

is there a easy example of building the infowindow somewhere that i can integrate javascript?


--
You received this message because you are subscribed to the Google Groups "Google Maps JavaScript API v3" group.
To post to this group, send email to google-map...@googlegroups.com.
To unsubscribe from this group, send email to google-maps-js-a...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/google-maps-js-api-v3?hl=en.


geoco...@gmail.com

unread,
Nov 1, 2011, 9:49:47 AM11/1/11
to Google Maps JavaScript API v3
On Nov 1, 5:45 am, Christopher Watson <chris.watso...@googlemail.com>
wrote:
> hey joseph,
>
> does loading an xml fall into a kml/kmz category?

Your page builds your own infowindows (so you can do what you want in
them). If they are created automatically by KmlLayer then google
creates the contents.

>
> is there a easy example of building the infowindow somewhere that i can
> integrate javascript?

See your script.
(hint: you need to wait for the infowindow to be added to the DOM
before you can use document.getElementById to access it)

-- Larry

>
> cheers
>
> Chris Watson
>
> Portfolio |http://vism.ag/inkplay
> Vis Mag |http://vism.ag<http://vism.ag/inkplay>
> Creative Maps |http://vism.ag/maps
> Blog | Edinburgh Creative
> Map<http://visualisationmagazine.com/blogvisualthinkmap/2011/10/edinburgh...>
> [image: Twitter] <http://twitter.com/visualthinkmap>tweeted: @CreativeEdin
> thx
> Follow @visualthinkmap <http://twitter.com/visualthinkmap> Reply
> <http://twitter.com/?status=@visualthinkmap%20&in_reply_to_status_id=1...>
> Retweet
> <http://twitter.com/?status=RT%20%40visualthinkmap%3A%20%40CreativeEdi...>
>  17:48 Oct-30<http://twitter.com/visualthinkmap/statuses/130702704514314240>
>   Get this email app!
> <http://www.wisestamp.com/apps/twitter?utm_source=extension&utm_medium...>
>
>  Get a signature like this.
> <http://r1.wisestamp.com/r/landing?promo=19&dest=http%3A%2F%2Fwww.wise...>
> CLICK
> HERE.<http://r1.wisestamp.com/r/landing?promo=19&dest=http%3A%2F%2Fwww.wise...>

xelawho

unread,
Nov 1, 2011, 10:59:42 AM11/1/11
to Google Maps JavaScript API v3
I don't really understand how your snippet relates to the issue, and
your map doesn't load for me (slow connection - can I suggest making a
separate map with just the functionality you are trying to get working
as a first step? saves people having to wade through reams of
irrelevant code and often isolates problems) but I would think that
adding the content you are trying to add at the time that you create
the infowindow is probably going to be the least problematic route.

I made another example which adds the url to the infowindow and also
uses the javascript escape and unescape functions to deal with
encoding and decoding the url, meaning that your markers can have any
sort of weird characters you like in them:
http://www.xelawho.com/map/markurl4.html

hope that helps.

Christopher Watson

unread,
Nov 1, 2011, 11:48:03 AM11/1/11
to google-map...@googlegroups.com
hi xela, 

yeah, i just come back to it now and was figuring out how to try it without the need to wade through code. i did it in the 'wades' of code as i load makers from an xml, not as seperate points like in your examples. 

Thanks for the new example i'm looking at it and i see this... 

infowindow.setContent(contentString+"<br>"+base+escape(marker.title));

...is it this thats putting it into the infowindow?

i'm trying to add the url to the sharethis widget.

so the url you put int the info window...


but inside here...

<div id="custom-tweet-button">
  <a href="http://twitter.com/share" class="twitter-share-button"
     data-url="the url inside here"
     data-counturl="the url inside here"
     data-count="vertical"
     data-via="visualthinkmap">Tweet</a>     
</div>


<span class="st_facebook_vcount" st_url="the url inside here' + name + '<\/a>" displayText="Share"></span>
<span class="st_email_vcount" st_url="the url inside here" displayText="Email"></span>
<span class="st_sharethis_vcount" st_url="the url inside here" displayText="Share"></span>


so... (he says just typing and not sure of coding format or errors)...

something like this:



infowindow.setContent(
<div id="custom-tweet-button">
  <a href="http://twitter.com/share" class="twitter-share-button"
     data-url="contentString+"<br>"+base+escape(marker.title));"
     data-counturl="contentString+"<br>"+base+escape(marker.title));"
     data-count="vertical"
     data-via="visualthinkmap">Tweet</a>     
</div>


<span class="st_facebook_vcount" st_url="contentString+"<br>"+base+escape(marker.title));' + name + '<\/a>" displayText="Share"></span>
<span class="st_email_vcount" st_url="contentString+"<br>"+base+escape(marker.title));" displayText="Email"></span>
<span class="st_sharethis_vcount" st_url="contentString+"<br>"+base+escape(marker.title));" displayText="Share"></span>


Would this be ok and does it make it bit clearer what i want to put in the infowindow, jsut love that a unique url is generated for a marker and wanted to utilise it in social sharing buttons.

again, all help greatly appreciated

thanks xela for the url in the window example.

chris








Chris Watson

Portfolio | http://vism.ag/inkplay 
Vis Mag | http://vism.ag

Creative Maps | http://vism.ag/maps 

Twitter tweeted: @CreativeEdin thx

Christopher Watson

unread,
Nov 1, 2011, 12:08:19 PM11/1/11
to google-map...@googlegroups.com
without all the wading of code http://creativemaps.vism.ag/infowindowurldev.htm

xelawho

unread,
Nov 1, 2011, 12:41:15 PM11/1/11
to Google Maps JavaScript API v3
without knowing anything about facebook or twitter or whatever, it
seems like it should work.

just keep an eye on your errors in firebug - there are lots of quotes
and brackets there that will need to be escaped.

Radina

unread,
Nov 2, 2011, 6:14:04 PM11/2/11
to Google Maps JavaScript API v3
Chris:

Have you checked Firebug errors? Yoo can try following

-----

google.maps.event.addListener(marker, 'click', function() {
infowindow.setContent(

contentString
+ "<div id='custom-tweet-button'>"
+ "<a href='http://twitter.com/share'
class='twitter-share-button' data-url='"
+ base + escape(marker.title)
+ "' data-counturl=' "
+ base+escape(marker.title)
+ "' data-count='vertical' data-
via='visualthinkmap'>Tweet</a></div>"

);
infowindow.open(map,marker);
});
---
and then add remaining three span lines

On Nov 1, 9:08 am, Christopher Watson <chris.watso...@googlemail.com>
wrote:
> without all the wading of codehttp://creativemaps.vism.ag/infowindowurldev.htm
>
> Chris Watson
>
> Portfolio |http://vism.ag/inkplay
> Vis Mag |http://vism.ag<http://vism.ag/inkplay>
> Creative Maps |http://vism.ag/maps
> Blog | Edinburgh Creative
> Map<http://visualisationmagazine.com/blogvisualthinkmap/2011/10/edinburgh...>
> [image: Twitter] <http://twitter.com/visualthinkmap>tweeted: @CreativeEdin
> thx
> Follow @visualthinkmap <http://twitter.com/visualthinkmap> Reply
> <http://twitter.com/?status=@visualthinkmap%20&in_reply_to_status_id=1...>
> Retweet
> <http://twitter.com/?status=RT%20%40visualthinkmap%3A%20%40CreativeEdi...>
>  17:48 Oct-30<http://twitter.com/visualthinkmap/statuses/130702704514314240>
>   Get this email app!
> <http://www.wisestamp.com/apps/twitter?utm_source=extension&utm_medium...>
>
>  Get a signature like this.
> <http://r1.wisestamp.com/r/landing?promo=19&dest=http%3A%2F%2Fwww.wise...>
> CLICK
> HERE.<http://r1.wisestamp.com/r/landing?promo=19&dest=http%3A%2F%2Fwww.wise...>
>
> On Tue, Nov 1, 2011 at 3:48 PM, Christopher Watson <
>
>
>
> chris.watso...@googlemail.com> wrote:
> > hi xela,
>
> > yeah, i just come back to it now and was figuring out how to try it
> > without the need to wade through code. i did it in the 'wades' of code as i
> > load makers from an xml, not as seperate points like in your examples.
>
> > Thanks for the new example i'm looking at it and i see this...
>
> > infowindow.setContent(contentString+"<br>"+base+escape(marker.title));
>
> > ...is it this thats putting it into the infowindow?
>
> > i'm trying to add the url to the sharethis widget.
>
> > so the url you put int the info window...
>
> > but inside here...
>
> > <div id="custom-tweet-button">
> >   <a href="http://twitter.com/share" class="twitter-share-button"
> >      data-url="*the url inside here*"
> >      data-counturl="*the url inside here*"
> >      data-count="vertical"
> >      data-via="visualthinkmap">Tweet</a>
> > </div>
>
> > <span class="st_facebook_vcount" st_url="*the url inside here*' + name +
> > '<\/a>" displayText="Share"></span>
> > <span class="st_email_vcount" st_url="*the url inside here*"
> > displayText="Email"></span>
> > <span class="st_sharethis_vcount" st_url="*the url inside here*"
> > displayText="Share"></span>
>
> > so... (he says just typing and not sure of coding format or errors)...
>
> > something like this:
>
> > infowindow.setContent(
> > <div id="custom-tweet-button">
> >   <a href="http://twitter.com/share" class="twitter-share-button"
> >      data-url="*contentString+"<br>"+base+escape(marker.title));*"
> >      data-counturl="*contentString+"<br>"+base+escape(marker.title));*"
> >      data-count="vertical"
> >      data-via="visualthinkmap">Tweet</a>
> > </div>
>
> > <span class="st_facebook_vcount" st_url="*contentString+"<br>"+base+
> > escape(marker.title));*' + name + '<\/a>" displayText="Share"></span>
> > <span class="st_email_vcount" st_url="*contentString+"<br>"+base+
> > escape(marker.title));*" displayText="Email"></span>
> > <span class="st_sharethis_vcount" st_url="*contentString+"<br>"+base+
> > escape(marker.title));*" displayText="Share"></span>
>
> > Would this be ok and does it make it bit clearer what i want to put in the
> > infowindow, jsut love that a unique url is generated for a marker and
> > wanted to utilise it in social sharing buttons.
>
> > again, all help greatly appreciated
>
> > thanks xela for the url in the window example.
>
> > chris
>
> > Chris Watson
>
> > Portfolio |http://vism.ag/inkplay
> > Vis Mag |http://vism.ag<http://vism.ag/inkplay>
> > Creative Maps |http://vism.ag/maps
>
> > Blog | Edinburgh Creative Map<http://visualisationmagazine.com/blogvisualthinkmap/2011/10/edinburgh...>
> >  [image: Twitter] <http://twitter.com/visualthinkmap> tweeted: @CreativeEdin
> > thx
> > Follow @visualthinkmap <http://twitter.com/visualthinkmap> Reply
> > <http://twitter.com/?status=@visualthinkmap%20&in_reply_to_status_id=1...> Retweet
>
> > <http://twitter.com/?status=RT%20%40visualthinkmap%3A%20%40CreativeEdi...>  17:48 Oct-30<http://twitter.com/visualthinkmap/statuses/130702704514314240>
> >   Get this email app! <http://www.wisestamp.com/apps/twitter?utm_source=extension&utm_medium...>
>
> >   Get a signature like this.
> > <http://r1.wisestamp.com/r/landing?promo=19&dest=http%3A%2F%2Fwww.wise...> CLICK
> > HERE.<http://r1.wisestamp.com/r/landing?promo=19&dest=http%3A%2F%2Fwww.wise...>- Hide quoted text -
>
> - Show quoted text -

Christopher Watson

unread,
Nov 2, 2011, 7:10:24 PM11/2/11
to google-map...@googlegroups.com
hi radina

thanks for the code, been trying to find something like this on the web all last night without real success. 

i added the code the to the xela example http://www.xelawho.com/map/markurl4.html

here is the one i have added the code too: http://creativemaps.vism.ag/1b.htm

firebug is probably easy (installed the chrome extension one) but not quite used to it, not sure how to debug, anyway i used the javascript console (on the 1b.htm) in chrome and it errors:

"uncaught syntax error: unexpected reserved word"

on this line: class='twitter-share-button' data-url='"

google'd but, whats an unexpected reserved word?

so, yeah i'm trying to debug with chrome and see how to write those + "' 's but struggle.

is this easy to fix? how?



Chris Watson

Portfolio | http://vism.ag/inkplay 
Vis Mag | http://vism.ag

Rossko

unread,
Nov 2, 2011, 9:56:57 PM11/2/11
to Google Maps JavaScript API v3
> on this line: class='twitter-share-button' data-url='"

The problem code is
+ "<a href='http://twitter.com/share'
class='twitter-share-button' data-url='"
To javascript, that is one string - everything between the two " -
split over two lines. Many browsers choke on that, the newline 'ends'
the string prematurely and so the browser tries to interpret the next
line as javascript and fails.
Avoid splitting strings over two lines, be especially careful when
copy/pasting others code.

Christopher Watson

unread,
Nov 3, 2011, 6:13:37 PM11/3/11
to google-map...@googlegroups.com
hi all,

sorry should've realised about the seperate lines. it was how my browser displayed the code you shared and i copied and pasted as was with it on the seperate lines. 

ok. 

it puts the link there, but isn't pulling in the unique url made for that pin. 



radina, did you manage to get it using the unique url generated? 

thanks for your help 

chris

sorry didn't get to this last night. 

Rossko

unread,
Nov 3, 2011, 7:37:41 PM11/3/11
to Google Maps JavaScript API v3
> it puts the link there, but isn't pulling in the unique url made for that
> pin.

See your listener code
contentString + "<div id='custom-tweet-button'>" + "<a href='http://
twitter.com/share' class='twitter-share-button' data-url='" + base +
escape(marker.title)

the href is always 'http://twitter.com/share' , there is nothing in
your code to change that.

I don't know what the variable data-url attribute is used for? You
probably want a ? character in there to seperate base url from params.

Radina

unread,
Nov 4, 2011, 6:56:25 PM11/4/11
to Google Maps JavaScript API v3
Hi Chris:

Re: just tries to tweet
http://creativemaps.vism.ag/1b.htm, not
http://creativemaps.vism.ag/1b.htmThis%20place

Please note that this is not valid url (nonexistent, if you try to
open it)
http://creativemaps.vism.ag/1b.htmThis%20place

I am not sure what expected behaviour is. When I clicked that button,
Twitter login page popped up

Thanks, Radina

Christopher Watson

unread,
Nov 5, 2011, 10:13:59 AM11/5/11
to google-map...@googlegroups.com
hey folks, 

thanks for all the help btw. i realise that the http://creativemaps.vism.ag/1b.htmThis%20place wasn't a url and didn't take you anywhere. 

fixed that, i used http://jsbin.com which was really helpful to quickly type and see what ', or ", + any little character effects the code, or even break in line to test online live. 

anyhow i arrived at this:


now these do work as a valid url, it does exist:


cool, i'm practically there. the javascript of data url and data count i think just doesnt work inside the head. i think they have to be in the body. used like you said rossko, i made it link from the http://twitter.com/share?url= 

but, ;o) ..... this is the url made at the bottom of the page http://creativemaps.vism.ag/1b.htm?Jimmy%27s%20place but when i go through the add this share link... i just test tweeting, this is the url that is made.... http://creativemaps.vism.ag/1b.htm?Jimmy's+place 

I think when it gets to twitter it changes the %27 back to '   and the %20 it changes to + . How can i keep the url as %27 & %20 that makes it the real link when its shared?

thanks

Christopher Watson

unread,
Nov 5, 2011, 12:42:37 PM11/5/11
to google-map...@googlegroups.com
interesting url encoding.... ;o)

i tested other sharing places and delicious just drops in _


email treats it like this:



Is it not possible to just strip out spaces and special characters from the url completely and still link to a marker? 

so this title of a marker is:

Jimmy's Place

url encoded is:


... this then surely wont have any ascii % encoding issues of different services to share too as all seem to handle the ? character without it changing or transmitting as % or anything. 

i could even take out all special characters from titles of markers and then its just a case of removing spaces and then rather than encode them through % just remove them from the url completely to leave this:


would it still work and take them to the pin like this http://creativemaps.vism.ag/1b.htm?Jimmy%27s%20place does?

all help really appreciated. 

thanks

chris




Rossko

unread,
Nov 5, 2011, 1:32:27 PM11/5/11
to Google Maps JavaScript API v3
> the javascript of data url and data count i
> think just doesnt work inside the head.

I'm not sure what you were expecting those attributes to do.
Guessing, you have some utility script that processes HTML tags with
those attributes. That kind of script doesn't work with infowindow
content easily, because the infowindow content doesn't exist at all
when the page is loaded and the utility script is run to search for
the special attributes. You'd need some way to prompt the magic
script to do its thing after the infowindow has been created and
populated. Search this group for 'lightbox' for an example of utility
script needing this kind of care.


> Is it not possible to just strip out spaces and special characters from the
> url completely and still link to a marker?
>
> so this title of a marker is:
>
> Jimmy's Place
>
> url encoded is:
>
> http://creativemaps.vism.ag/1b.htm?Jimmysplace

Yes, that's perfectly possible and could save pain. It will muddle up
similar things like Jimmy's Place and Jimmys Place and JimmysPlace,
but you might well not care about that

> would it still work and take them to the pin like thishttp://creativemaps.vism.ag/1b.htm?Jimmy%27s%20placedoes?

So long as you write your code to compare the input from the URL
parameter with a similarly-processed version of your original data

Christopher Watson

unread,
Nov 5, 2011, 7:55:19 PM11/5/11
to google-map...@googlegroups.com
hey all, 

ok, came across this script that replaces white spaces for - (hyphen) avoiding %20.

for(var i=0;i<gmarkers.length;i++)
    str = str.replace(gmarkers[i][1],gmarkers[i][0]);
  // first replace whitespace by -, second remove repeated - by just one, third turn in low case the chars,
  // fourth delete all chars which are not between a-z or 0-9, fifth trim the string and
  // the last step truncate the string to 32 chars 
  return str.replace(/\s+/g,'-').replace(/\-{2,}/g,'-');


i have tried to adapt it into my page, but its not putting - (hyphen) into the space. not sure what i'm doing wrong, 


please help so it replaces spaces with an hyphen, or even just take them out. 

any help much appreciated

Rossko

unread,
Nov 6, 2011, 8:17:27 AM11/6/11
to Google Maps JavaScript API v3
> i have tried to adapt it into my page, but its not putting - (hyphen) into
> the space. not sure what i'm doing wrong,
> http://creativemaps.vism.ag/1c.htm

You've added your code so that it will process any parameters passed
in via the URL.
You haven't added any code that will do anything to your marker or
infowindow content.

This isn't Maps, its general javascripting.

Christopher Watson

unread,
Nov 6, 2011, 9:09:11 AM11/6/11
to google-map...@googlegroups.com
had another look at it. 

dont need to edit the code as much as i did. 

i have taken the adding % part out, and just tried loading the friendly_url(str,max) through an onclick inside a div in the content string


still no success. it might be general javascripting but i cant work out what its missing or why its not swapping the spaces for hyphens. 

please if you can see the way to fix help direct me

thanks

chris

Rossko

unread,
Nov 6, 2011, 9:40:12 AM11/6/11
to Google Maps JavaScript API v3
> http://creativemaps.vism.ag/1c.htm
>
> still no success. it might be general javascripting but i cant work out
> what its missing or why its not swapping the spaces for hyphens.

I think that must be because you're not grasping the flow of the
script.
You have a tilesloaded listener that when triggered, reads the url
input parameters (query string) and compares that with your markers.
If it finds one, it triggers a click on that marker. Then processes
friendly_url(str,max) where neither 'str' nor 'max' have been defined
to be anything. Does that not strike you as doing things in the wrong
order?

In your code that sets up the infowindow content, you have
" ... onclick='friendly_url(str,max)'>" ...
This will set up so that when the user clicks that div,
friendly_url(str,max) will be executed. I think what you intend is to
use friendly_url() to process the string you are going to show in the
infowindow, before you populate the infowindow. To use friendly_url()
at all, you will have to tell it what to operate on, 'str' isn't
defined

None of this is maps related. You might look outside the maps world
for help with basic javascript concepts, such as passing arguments to
functions.

Christopher Watson

unread,
Nov 7, 2011, 6:51:55 PM11/7/11
to google-map...@googlegroups.com
hey all, 

fixed the creating the dashed url's to this http://creativemaps.vism.ag/1c.htm?Jimmys-place

yay. but it doesnt automatically display the infowindow after the url is accessed like this would have:


i tried placing google.maps.event.addListener(marker, "click", marker.openInfoWindow);

inside here:

  function dasherize(title) {
    
    return title.replace(/\s+/g,'-').replace(/'/g, ''); 
google.maps.event.addListener(marker, "click", marker.openInfoWindow);
    
  }

even:

  function dasherize(title) {
    
    return title.replace(/\s+/g,'-').replace(/'/g, ''); 
    google.maps.event.trigger(gmarkers[i], "click");
  }

but doesn't work.
please help, how can i make it trigger the info of the linked marker to display like in the %20... url's?

Rossko

unread,
Nov 7, 2011, 7:28:00 PM11/7/11
to Google Maps JavaScript API v3
>   function dasherize(title) {
>     return title.replace(/\s+/g,'-').replace(/'/g, '');
> google.maps.event.addListener(marker, "click", marker.openInfoWindow);
>   }

Investigate what happens when javascript encounters a 'return' inside
a function. This is not a maps issue. Example javascript function
tutorial
http://www.quirksmode.org/js/function.html
It will be quicker for you to learn some rudiments of javascript, than
trying to insert code snippets at random places in your code.

As your dasherize() function is about massaging a string, it's
probably not a good place to be putting something to do with markers
that it knows nothing about.

Andrew Leach

unread,
Nov 7, 2011, 7:30:12 PM11/7/11
to google-map...@googlegroups.com
On 7 November 2011 23:51, Christopher Watson

<chris.w...@googlemail.com> wrote:
>
> hey all,
> fixed the creating the dashed url's to this http://creativemaps.vism.ag/1c.htm?Jimmys-place
> yay. but it doesnt automatically display the infowindow after the url is accessed like this would have:

That's because this test fails:
if (newtarg==gmarkers[i].title)

You need to test things that are actually going to be equal, so it
looks like this might work:
if (newtarg==dasherize(gmarkers[i].title))
because the result of the function is "Jimmys-place" which is what newtarg is.

Christopher Watson

unread,
Nov 7, 2011, 8:05:47 PM11/7/11
to google-map...@googlegroups.com
it worked andrew, many thanks all of you for the help in translating this: http://www.xelawho.com/map/markurl4.html

...into this: http://creativemaps.vism.ag/1c.htm (will try remember to leave this file up on site when tidying server, or much of it here: http://jsbin.com/efaquw/edit#javascript,html,live bar the last edit from andrew)

these work now:


the prototype's there, i'll soon have some fun getting it into the main site.

really, many thanks. 
Reply all
Reply to author
Forward
0 new messages