Is the code review server working?

[Paulo Pinto]

Hi everyone,

when I try to upload my contributions to the code review server I get
the following error,

$ hg mail 4528073
JSONGet /api/4528073?messages=true: exceptions.ImportError: No module
named json
cannot load CL 4528073 from server

Does anyone else have similar issues?

Thanks,
Paulo

[Paulo Pinto]

Hi,

found out what the problem was.

codereview.py now depends on json, which was not part of the
library.zip contents in
MinGW\msys\1.0\bin location.

If you happen to use the mingw package for Go development, you might
need to update
the library.zip file contents.

--
Paulo

[mattn]

You need change a file in the library.zip .

Perhaps, you add directory 'json' into the library.zip .

Extract json/scanner.py and open the file.

You can see following code.

-------------------------------------

"""JSON token scanner

"""

import re

try:

    from _json import make_scanner as c_make_scanner

except ImportError:

    c_make_scanner = None

...

-------------------------------------

Then, add 1 line.

-------------------------------------

"""JSON token scanner

"""

import re

try:

    from _json import make_scanner as c_make_scanner

except ImportError:

    c_make_scanner = None

c_make_scanner = None # disable C scanner.

...

-------------------------------------

Perhaps, the error will be fixed.

Thanks.

- Yasuhiro Matsumoto