Disable directory listing with http.FileServer

[Trung Pham]

Hi,

I'm using the built in static file http.FileServer.

Do you know if there is an easy way to disable the directory listing? Just simply return a 404.

Thanks.

[minux]

On Tue, Oct 9, 2012 at 3:50 PM, Trung Pham <tr...@phamcom.com> wrote:

I'm using the built in static file http.FileServer.

Do you know if there is an easy way to disable the directory listing? Just simply return a 404.

func noDirListing(h http.Handler) http.HandlerFunc {

return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

if strings.HasSuffix(r.URL.Path, "/") {

http.NotFound(w, r)

return

}

h.ServeHTTP(w, r)

})

}

func main() {

http.Handle("/", noDirListing(http.FileServer(http.Dir("./static/"))))

log.Println(http.ListenAndServe(":8080", nil))

}

[Brad Fitzpatrick]

package main

import (

"net/http"

"os"

)

type justFilesFilesystem struct {

fs http.FileSystem

}

func (fs justFilesFilesystem) Open(name string) (http.File, error) {

f, err := fs.fs.Open(name)

if err != nil {

return nil, err

}

return neuteredReaddirFile{f}, nil

}

type neuteredReaddirFile struct {

http.File

}

func (f neuteredReaddirFile) Readdir(count int) ([]os.FileInfo, error) {

return nil, nil

}

func main() {

fs := justFilesFilesystem{http.Dir("/tmp/")}

http.ListenAndServe(":8080", http.FileServer(fs))

}

--
 
 

[Trung Pham]

Thanks. It worked perfectly.

From looking the fileServer source code, it always redirects /assets to /assets/. I hope that this functionality will not go away, else it will break this code. :)

[Henrik Johansson]

The simplicity of this tiny bit of code is such a big part of what I
like about Go that I would probably settle for this alone.
It has all the concepts of the entire type system all in one little
functional snippet. Well damn near at least.

Pretty!

> --
>
>

[ilkergok...@gmail.com]

A more cleaner approach would be like this:

publicPath = "./public"

router.Methods("GET").PathPrefix("/").HandlerFunc(publicHandler)

func publicHandler(w http.ResponseWriter, r *http.Request) {

path := publicPath + "/" + r.URL.Path

if f, err := os.Stat(path); err == nil && !f.IsDir() {

http.ServeFile(w, r, path)

return

}

http.NotFound(w, r)

}

[Ingo Oeser]

Brad, would you mind adding that as an example to net/http? Most of the asset helper libraries out there solve mostly this problem for users in a bloated way.

[arm...@gmail.com]

I've settled on the following, which has the added benefit of returning 404 for directories.

Corrections appreciated.

type justFilesFilesystem struct {
   Fs http.FileSystem

}

func (fs justFilesFilesystem) Open(name string) (http.File, error) {

   f, err := fs.Fs.Open(name)

   if err != nil {
      return nil, err
   }

   stat, err := f.Stat()
   if stat.IsDir() {
      return nil, os.ErrNotExist
   }

   return f, nil
}

[ko...@ekanna.com]

It won't serve index.html file by default like in case of neuteredReaddirFile