VREF/MAX_NEWBIN_SIZE does not handle deletion

36 views
Skip to first unread message

Thomas Gerbet

unread,
Feb 25, 2019, 8:45:41 AM2/25/19
to gitolite
Hi all,

We found a small issue with the MAX_NEWBIN_SIZE script. If a reference is deleted in a repository where this virtual ref is active, the script is not capable of handling it correctly:

remote: fatal: bad object 0000000000000000000000000000000000000000
remote: error: unable to find 0000000000000000000000000000000000000000
remote: fatal: Not a valid object name 0000000000000000000000000000000000000000


I have attached a small patch proposal fixing the issue.


Regards
0001-Handle-reference-deletion-in-VREF-MAX_BIN_SIZE.patch

Sitaram Chamarty

unread,
Feb 26, 2019, 10:19:48 AM2/26/19
to Thomas Gerbet, gitolite
On Mon, Feb 25, 2019 at 02:45:27PM +0100, Thomas Gerbet wrote:

> +if ($newsha eq '0000000000000000000000000000000000000000') {
> + exit 0;
> +}

Thanks!

I hope you don't mind if I change it to

exit 0 if $newsha eq '0000000000000000000000000000000000000000';

when I push.

Thomas Gerbet

unread,
Feb 26, 2019, 10:24:27 AM2/26/19
to Sitaram Chamarty, gitolite
Absolutely not!

Thanks for your work.
Reply all
Reply to author
Forward
0 new messages