Extensions on Firebug 1.8 (YSlow issue)

[Marcel Duran]

Hi,

I'm the YSlow maintainer and noticed the last Firebug 1.8.0b7 is not
invoking *initialize* function on YSlow Firebug Module:


Firebug.YSlow = FBL.extend(Firebug.Module, {
initialize: function (prefDomain, prefNames) {

// ... UNREACHEABLE CONTENT ... //

},

// ... //
});

function YSlowFBPanel() {}
YSlowFBPanel.prototype = FBL.extend(Firebug.Panel, {
name: "YSlow",
// ... //

initialize: function (context, doc) {
// ... reachable content ...//
},

// ... //
});

Firebug.registerModule(Firebug.YSlow);
Firebug.registerPanel(YSlowFBPanel);


The YSlow for Firebug code wasn't changed and it's working properly on
FF5 with Firebug 1.7.3.

Any recent changes we should be aware of?


Thanks,

Marcel

[Jan Honza Odvarko]

I don't see any reason why the initialize methods wouldn't be called.

I have put together a simple HelloWorld extension that registers
one module and one panel and the initialize method is properly
called for both.
http://code.google.com/p/fbug/source/browse/#svn%2Fexamples%2Ffirebug1.9%2FHelloWorld

Check Firefox Error console and Firebug Tracing Console (FBTrace)
for possible exception that blocks the execution.

Don't forget that two globals have been removed:

FirebugContext -> Firebug.currentContext
FirebugChrome -> Firebug.chrome

Honza

[Ceasar Feijen]

latest 1.8.1.B1 windows 7 firefox 5.0
Yslow isn't working anymore

[James Abley]

On Aug 5, 11:20 am, Ceasar Feijen <cfconsulta...@gmail.com> wrote:
> latest 1.8.1.B1 windows 7 firefox 5.0
> Yslow isn't working anymore

This may be unrelated, but YSlow stopped working for me after a recent
Firebug upgrade. AFAIK, nothing else has changed in my environment.

Firefox 5.0.1
OSX Snow Leopard 10.6.8
Firebug 1.8.0
YSlow 3.0.3

I see this in the logs:

Error: FBL.getAncestorByClass is not a function
Source File: chrome://firebug/content/firefox/bindings.xml
Line: 443

Error: FBL.$STR is not a function
Source File: chrome://firebug/content/firefox/bindings.xml
Line: 1391

"YSLOW.firefox.startup():TypeError: FBL.extend is not a function"

Cheers,

James

[Jan Honza Odvarko]

On Aug 9, 1:31 pm, James Abley <james.ab...@gmail.com> wrote:
> On Aug 5, 11:20 am, Ceasar Feijen <cfconsulta...@gmail.com> wrote:
> Error: FBL.getAncestorByClass is not a function
> Source File: chrome://firebug/content/firefox/bindings.xml
> Line: 443
>
> Error: FBL.$STR is not a function
> Source File: chrome://firebug/content/firefox/bindings.xml
> Line: 1391

These errors should be fixed in Firebug 1.8.1b1

> "YSLOW.firefox.startup():TypeError: FBL.extend is not a function"

It looks like the startup method is called too soon.
FBL.extend method is properly set in lib.js
(I can see that when having Firebug running).

Honza

>
> Cheers,
>
> James

[James Abley]

Thanks for that recommendation. I've upgraded to 1.8.1b1 and I now see
the YSlow tab again, but new error in the logs:

Error: FirebugContext is not defined
Source File: chrome://yslow/content/yslow-firebug.js
Line: 134

I'll patch that locally and see about submitting a patch for YSlow.

Thanks for your help.

Cheers,

James

[Jan Honza Odvarko]

On Aug 9, 1:52 pm, James Abley <james.ab...@gmail.com> wrote:
> Thanks for that recommendation. I've upgraded to 1.8.1b1 and I now see
> the YSlow tab again, but new error in the logs:
>
> Error: FirebugContext is not defined
> Source File: chrome://yslow/content/yslow-firebug.js
> Line: 134

Firebug is avoiding globals, use:

[James Abley]

Yeah, I got that from your earlier post, thank you.

I can confirm that YSlow now appears to work fine in my environment.

1. Unzip existing yslow xpi.
2. Search and replace for usages of globals mentioned (chrome/content/
yslow-firebug-net.js, chrome/content/yslow-firebug.js and chrome/
content/yslow-firefox.js).
3. Zip to create a new xpi.
4. Install the new xpi.

It's a little disappointing that YSlow doesn't appear to have a bug
tracker or way of submitting patches, plus the problem has been known
of for a while [1].

I'd like to see YSlow on github or similar, and am willing to help
make that happen if the right people are on this list?

Cheers,

James

[1] http://tech.groups.yahoo.com/group/exceptional-performance/message/1927

[Marcel Duran]

We've already submitted a new YSlow release to Mozilla Addon gallery
which is still pending full review.
The new version 3.0.4 is Firebug 1.8 compatible.

Marcel

[Marventus]

Hi Marcel,

First of all, thanks for a wonderful add-on.
I would like to report a problem that other users might be having as
well.
After updating Firebug to 1.8.2, on Firefox 5.0.1, YSlow 3.0.4.
stopped working. The icon appears on the Add-on bar, but clicking on
it does nothing and the tab is not visible in Firebug. I tried rolling
back to 3.0.3 but was not able to.
Reverting to Firebug 1.8.1 fixes the problem.
Thanks in advance for looking into this.

Marventus


On Aug 9, 2:45 pm, Marcel Duran <marceldu...@gmail.com> wrote:
> We've already submitted a newYSlowrelease to Mozilla Addon gallery

[Ceasar Feijen]

I can confirm this issue