How to handle nasty race condition for 0.9.1

[Charles Allen]

https://github.com/druid-io/druid/pull/2521 introduced a race condition described in https://github.com/druid-io/druid/issues/3174 when druid.indexer.runner.pendingTasksRunnerNumThreads is set greater than one. As such I have proposed https://github.com/druid-io/druid/pull/3184 for 0.9.1 which sets the default case to retain behavior prior to #2521

We have one of two routes to go down here:

1. Set the default for pendingTaskRunnerNumThreads to 1 and label it as experimental to set any higher, fix the bug in 0.9.2
2. Fix the bug for 0.9.1 and add proper concurrency unit tests in RemoteTaskRunnerTest

I'm inclined to take #1 but would like to hear community feedback.

[Gian Merlino]

I am in favor of #1 given that this was a new feature added for 0.9.1 and did not previously exist.

Gian

--
You received this message because you are subscribed to the Google Groups "Druid Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to druid-developm...@googlegroups.com.
To post to this group, send email to druid-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/druid-development/1ffcffea-8cac-453d-9b7a-b8358e4debb9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Gian Merlino]

PR for #1: https://github.com/druid-io/druid/pull/3185

Gian