Url splitted into separate modules for easier including and overidding.

14 views
Skip to first unread message

jrief

unread,
Dec 17, 2011, 6:44:33 PM12/17/11
to djang...@googlegroups.com
There is a problem with this patch: the welcome page is gone.

Also, what's the benefit for not writing the urlpatterns in shop/urls.py like this?

urlpatterns = patterns('',
    (r'^pay/', include('shop.payment.urls')),
    (r'^ship/', include('shop.shipping.urls')),
    (r'^order/', include(urls_order)),
    (r'^checkout/', include(urls_checkout)),
    (r'^cart/', include(urls_cart)),
    (r'^products/', include(urls_catalog)),
(r'^$', ShopTemplateView.as_view(template_name="shop/welcome.html")),

    )

this would be easier to read and would avoid some code duplication in the sub-urlpatterns.
The last line is the missing welcome page.

Jacob

jrief

unread,
Dec 18, 2011, 5:10:49 PM12/18/11
to djang...@googlegroups.com
I just sent a pull request fixing these issues.
Reply all
Reply to author
Forward
0 new messages