Schema Alteration - Review needed!

[Andrew Godwin]

Hi all,

I have now, I believe, got a working, feature-complete schema alteration branch ready to go. It has full support for PostgreSQL, MySQL, and SQLite, and follows the rough design principles I emailed the list about a while back.

It's fully tested, but no documentation yet - I'm not sure what level of documentation we should give this, but it is my intention for it to be an API usable by third-party apps. In the meantime, the tests file should give you a reasonable idea of the way the API can be used (if you ignore the slightly cheap way to make new model classes - 'migrations' has a much nicer one of those).

It should be Python 3 compatible, too - I've checked the major pain points and run the test suite under Python 3, and it all passes.

The branch is schema-alteration in https://github.com/andrewgodwin/django

Handy link to the diff-with-master view: https://github.com/andrewgodwin/django/compare/schema-alteration

Feedback is very much welcomed - I want to get this merged in before the feature freeze.

There's doubtless some polishing and bugfixing that will be needed before final release, but I'll be keeping on top of that (by developing an app that uses it, partially) and making sure that 1.5 ships with something that's decently solid, and with an Oracle backend if I can get it working on my machine.

Andrew

[Alex Gaynor]

Andrew

--
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to django-d...@googlegroups.com.
To unsubscribe from this group, send email to django-develop...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.

Hi Andrew,

Can you put this in a pull-request so I can comment inline?

Thanks,

Alex

--
"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero

[Andrew Godwin]

Can you put this in a pull-request so I can comment inline?

I can indeed: https://github.com/django/django/pull/376

Andrew 

[Jani Tiainen]

18.9.2012 1:59, Andrew Godwin kirjoitti:
> Hi all,

>
>
> There's doubtless some polishing and bugfixing that will be needed
> before final release, but I'll be keeping on top of that (by developing
> an app that uses it, partially) and making sure that 1.5 ships with
> something that's decently solid, and with an Oracle backend if I can get
> it working on my machine.

I can help with Oracle problems if you encounter a such thing since
that's my main backend I work with. (And I have to deal with all the
pain it causes)

> --
> You received this message because you are subscribed to the Google
> Groups "Django developers" group.
> To post to this group, send email to django-d...@googlegroups.com.
> To unsubscribe from this group, send email to
> django-develop...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.

--
Jani Tiainen

- Well planned is half done and a half done has been sufficient before...

[Andrew Godwin]

An update from discussions with Alex and Anssi - I'm going to modify things a little so we don't have a Borg-pattern AppCache (i.e. you can instantiate it multiple times and get different caches), which should solve most of the problems currently caused by app cache state fiddling. Should take a day or two.

I can help with Oracle problems if you encounter a such thing since that's my main backend I work with. (And I have to deal with all the pain it causes)

Thanks Jani - that would be much appreciated. It should be possible to get a decent way just from the Oracle module, I'll let you know when I get around to it. 

Andrew

[Andrew Godwin]

Alright, I've now removed my AppCache state handling and replaced it with swappable AppCaches - surprisingly, doing this hasn't broken anything, but it did need an AppCacheWrapper to stop references going wrong.

The commits are here:

https://github.com/andrewgodwin/django/commit/dbc17d035b255a4da977251fe399f5c80cffeecd

https://github.com/andrewgodwin/django/commit/49d1e6b0e20a363cbf9b105e8e6d3fc5fc1cad2f

The SQLite test suite all passes after these changes, so this is looking good. Thoughts?

Andrew