[1.4] SECRET_KEY deprecation is confusing...

[Nick Pope]

Hi,

There is a problem in 1.4rc2 where a missing SECRET_KEY causes Django to refuse to start.

According to the current version of the release notes on the website: In Django 1.4, starting Django with an empty SECRET_KEY will raise a DeprecationWarning. In Django 1.5, it will raise an exception and Django will refuse to start.

This doesn't make sense...  It currently raises DeprecationWarning which is an exception which causes Django to fail to start.  To trigger a deprecation warning while allowing execution to continue you need to use warnings.warn().

As things stand you are essentially implementing the behaviour for both 1.4 and 1.5!

Cheers,

Nick

[Carl Meyer]

On 03/15/2012 07:52 AM, Nick Pope wrote:
> There is a problem in 1.4rc2 where a missing SECRET_KEY causes Django to
> refuse to start.
>
> According to the current version of the release notes on the

> website: *In Django 1.4, starting Django with an empty SECRET_KEY will

> raise a DeprecationWarning. In Django 1.5, it will raise an exception

> and Django will refuse to start.*
> *
> *

> This doesn't make sense... It currently raises DeprecationWarning which
> is an exception which causes Django to fail to start. To trigger a
> deprecation warning while allowing execution to continue you need to use
> warnings.warn().
>
> As things stand you are essentially implementing the behaviour for both

> 1.4 *and* 1.5!

Indeed; thanks for the report. I've now fixed it to use warnings.warn,
as it should have originally.

Carl