Proposal: remove django-dbgettext support for cms content in 2.2

[Jonas Obrist]

Hi Devs

I propose dropping django-dbgettext support in the CMS in 2.2, which would mean before we release 2.1 we need to put Deprecation Warnings in there, which is why I bring this up now.

Why should we do that?

- It's an 100% untested feature

- Noone I know uses it, so again, I don't know if it works

- It duplicates a feature we already handle, doubling the work for us

- I personally believe it's a bad idea anyway.

Does anyone have any good arguments against dropping it?

Jonas

[Jannis Leidel]

Jonas Obrist wrote:
> Hi Devs
>
> I propose dropping django-dbgettext support in the CMS in 2.2, which would
> mean before we release 2.1 we need to put Deprecation Warnings in there,
> which is why I bring this up now.

+1 for the exact same reasons you mentioned.

Jannis

[?yvind Saltvik]

No arguments against dropping django-dbgettext by be.

Øyvind

[yml]

I don't even know what you are talking about to I guess I am not using it  :-)

[Jonas Obrist]

By default it is disabled, so you probably don't use it.

[Stefan Foulis]

+1 for removal

[Tribaal]

+1 for removal from me as well.

[Piotr Kilczuk]

+2 (colleague asked me to ;)

Regards,
Piotr

[Ruben]

+1 just to keep it DRY

.. but anyone there AGAINST removal??

[Jonas Obrist]

A deprecation warning was added and this feature will be dropped in 2.2.

[Jonas Obrist]

I've done this in a branch: https://github.com/ojii/django-cms/tree/feature/dbgettext-removal

I'd like to have at least another +1 for that branch from another core dev before I merge.

[Tribaal]

Well, all core devs +1'd, except erobit.

Eric, anything specific?

Otherwise, go ahead and merge ;)

- Trib'