[Feature Claim] 12) Update all references to bootstrap to be unified (use a gem?)

[Steven Hancock]

From the wishlist: https://github.com/diaspora/diaspora/wiki/Developer-Feature-Wishlist

I might as well claim this one since I've already started work on this as part of my ongoing work on the asset-pipeline branch.

At the moment I'm sure there are things that need to be fixed, but I have everything in the web and mobile UI relying on the vendored Bootstrap stylesheets from the bootstrap-sass gem. I chose the bootstrap-sass gem because I have experience working with it, it works quite well with the asset pipeline (without introducing a dependency on TheRubyRacer like many other Bootstrap gems do) and ActiveAdmin already includes it as a dependency anyway. :)

[Maxwell Salzberg]

Hey Steven,

I mentioned this in a commit message, but worth noting here as well.

I'd love to get the asset-pipeline in first.  That way we can get people to test and vet that everything works great.  Then, it makes sense to gem-ify whatever dependencies we can push the asset pipeline, and push that second.  That way it will be easier to see if/where things break?

Does that make sense, or do I sound like a crazy person :P ?

-m

--
You received this message because you are subscribed to the Google Groups "diaspora-dev" group.
To view this discussion on the web visit https://groups.google.com/d/msg/diaspora-dev/-/0766o6AiOdYJ.
To post to this group, send email to diaspo...@googlegroups.com.
To unsubscribe from this group, send email to diaspora-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/diaspora-dev?hl=en.

[Steven Hancock]

That makes sense to me. There are still a couple little bugs I'm
noticing in the asset-pipeline branch that have me scratching my
head.. for example if I'm on the stream page and click to any other
page, then click the back button (in FF7) I end up with my stream as
JSON instead of the right page.

If you like, I can go ahead and revert that commit and push it to a
separate branch for now (so I at least keep the little bit of work
I've already done on it.. lol). Some of the refactoring of certain
things into SASS partials should probably have been in a separate
commit anyway. :)

On Mar 27, 10:18 am, Maxwell Salzberg <maxw...@joindiaspora.com>
wrote:

> Hey Steven,
>
> I mentioned this in a commit message, but worth noting here as well.
>
> I'd love to get the asset-pipeline in first.  That way we can get people to
> test and vet that everything works great.  Then, it makes sense to gem-ify
> whatever dependencies we can push the asset pipeline, and push that second.
>  That way it will be easier to see if/where things break?
>
> Does that make sense, or do I sound like a crazy person :P ?
>
> -m
>

[Maxwell Salzberg]

Steven,

That would be awesome.

We pushed a big change with lots of new js today from a long running
branch, which is feature flagged for now while we finish it. I got
most of the updates working in the revised asset pipeline branch, and
I'd be awesome if you could take a look and work from there.

Also, did you get the other emails I sent you? Maybe I had a typo in
your address.

- Maxwell

[Steven Hancock]

Got the emails, but I had to look for them (you don't even want to
know what my gmail inbox looks like, I'm nowhere near inbox zero lol),
I set up a filter to label any future emails from you and also forward
them to my blackberry, so they should be easier to find. :)

Pushed the rebased-asset-pipeline branch to my pod and I have no
errors in firebug, but my feed never renders (firebug shows that the
JSON is downloaded). I'm generating fixtures now to run the jasmine
tests and see if I can find the problem.

Feeling a little under the weather right now, lack of sleep over the
past week and the cold my niece brought home from school, but I'll
keep working on this and the email refactors as much as I can and
hopefully we'll have something ready to merge into master soon.

On Mar 27, 9:20 pm, Maxwell Salzberg <maxw...@joindiaspora.com> wrote:
> Steven,
>
> That would be awesome.
>
> We pushed a big change with lots of new js today from a long running
> branch, which is feature flagged for now while we finish it. I got
> most of the updates working in the revised asset pipeline branch, and
> I'd be awesome if you could take a look and work from there.
>
> Also, did you get the other emails I sent you? Maybe I had a typo in
> your address.
>
> - Maxwell
>