Cleaning up old UI code

141 views
Skip to first unread message

Garry Boyer

unread,
Aug 6, 2013, 1:12:45 PM8/6/13
to clos-discuss
So it doesn't catch anyone by surprise -- in the next few weeks you may see parts of goog.ui removed. These are UI components that never got any usage within Google, and we tend to remove things with no usage because it means nobody is keeping us honest and helping us ensure they continue to work.

Additionally, we will be marking various UI components as deprecated if they have a more modern alternative, or if they don't fit Closure's design direction.

These are always recoverable via the version control system. We expect that some of these may even come back to life in Google some day, once someone has time to double check that they work. :-)

buend...@gmail.com

unread,
Aug 6, 2013, 4:26:31 PM8/6/13
to closure-lib...@googlegroups.com
So you just remove the old ones, without making the new ones open source?

The most requested plugin for closure editor, since 2010, is the image plugin, used in gmail, blogger and more. It has never been open sourced.

Also, google never open sourced any of the more modern ui components developed for g+.

I understand that this is google's library, and the company may not wish to open source it all. What I don't understand is, what does google think the value of this half dead project would be for the developers. I call this project half dead, as since its birth in 2009, almost no new features have been added, and all the commits, which are fairly sparse, are more or less cosmetic changes.

Nathan Naze

unread,
Aug 6, 2013, 4:36:40 PM8/6/13
to closure-library
goog.ui.* is only used by a subset of teams at Google that use
Closure, and that usage is dropping off, as teams move to other UI
rendering systems. As such, there has not been much activity in the
section of the code, nor do we have large plans to expand. It's kept
for the legacy users that have been using the code going back
2005/2006. Garry is doing some cleanup. I'm happy to expand on this
for anyone who has questions, or deal with the question in a
overview/policy document.

What has been developing steadily is the "standard library" part of
the library, and that is used very heavily throughout Google, and is
the primary focus of development (in tandem with the sister project,
the compiler).

> I call this project half dead, as since its birth in 2009, almost no new features have been added, and all the commits, which are fairly sparse, are more or less cosmetic changes.

I believe this is an inaccurate statement.
https://code.google.com/p/closure-library/source/list

Nathan
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to closure-library-d...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Daniel Steigerwald

unread,
Aug 6, 2013, 4:54:54 PM8/6/13
to closure-lib...@googlegroups.com
To make things perfect clear, Closure Library is awesome low level library. If you need more abstract components, like image uploader or MVC framework, you have to write it, but it will be nice and easy wheel reinventing, because library provides you solid foundations. On the contrary, if you need drop&go components or MVC framework, it would be better to use jQuery or Sencha puzzle.

buend...@gmail.com

unread,
Aug 6, 2013, 6:53:24 PM8/6/13
to closure-lib...@googlegroups.com


On Tuesday, August 6, 2013 9:36:40 PM UTC+1, Nathan Naze wrote:
goog.ui.* is only used by a subset of teams at Google that use
Closure, and that usage is dropping off, as teams move to other UI
rendering systems.

Are these other UI rendering systems built on top of closure library, or built on top of completely different technologies?

Could you list which parts are planned to be removed? I hope Toolbar is not one of them.

> email to closure-library-discuss+unsub...@googlegroups.com.

Nick Santos

unread,
Aug 6, 2013, 10:02:31 PM8/6/13
to closure-lib...@googlegroups.com
thank you for doing this. There's a lot of junk in goog.ui.

I am still holding my breath for goog.ui2!
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to closure-library-d...@googlegroups.com.

Nathan Naze

unread,
Aug 6, 2013, 10:07:23 PM8/6/13
to closure-library
> Could you list which parts are planned to be removed? I hope Toolbar is not one of them.

Garry can elaborate on exactly which he plans to drop, but I can tell
you now that Toolbar is unlikely to be removed. He is dropping things
with little usage in Google or that are no longer applicable with --
Toolbar, of course, is used widely and not on the chopping block.

Things being dropped are still going to always available in the
archives and can be branched out.

Nathan

Garry Boyer

unread,
Aug 7, 2013, 5:17:07 PM8/7/13
to clos-discuss
So far I'm starting to remove SplitBehavior, CustomColorPalette, DragDropSelector, Gauge, MenuBar (though it may come back if someone takes an interest in fixing it up and getting something that has a menu bar like Google Docs to adopt it).

buend...@gmail.com

unread,
Aug 7, 2013, 8:01:34 PM8/7/13
to closure-lib...@googlegroups.com


On Wednesday, August 7, 2013 10:17:07 PM UTC+1, Garry Boyer wrote:
So far I'm starting to remove SplitBehavior, CustomColorPalette, DragDropSelector, Gauge, MenuBar (though it may come back if someone takes an interest in fixing it up and getting something that has a menu bar like Google Docs to adopt it).

What's the difference between MenuBar and the menu bar used in google docs? They seem to have the same functionality.

Why is that the menu bar in google docs is not part of open source closure library?
 



>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups "Closure Library Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to closure-library-discuss+unsub...@googlegroups.com.

> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--

---
You received this message because you are subscribed to the Google Groups "Closure Library Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to closure-library-discuss+unsub...@googlegroups.com.

Garry Boyer

unread,
Aug 7, 2013, 8:08:38 PM8/7/13
to clos-discuss
The one in Google Docs came first, and its version of menu bar is already used by a half dozen different apps in the Drive suite :-) It also has special requirements, such as common actions specific to Docs/Drive. Teams at Google constantly working on features and rewriting existing code, so we tend to focus on rewrites that help launch new features, and my guess is their menu bar is not causing them any trouble at the moment.

To unsubscribe from this group and stop receiving emails from it, send an email to closure-library-d...@googlegroups.com.

Michal Sänger

unread,
Aug 8, 2013, 3:37:13 AM8/8/13
to closure-lib...@googlegroups.com

On Wednesday, August 7, 2013 11:17:07 PM UTC+2, Garry Boyer wrote:
So far I'm starting to remove SplitBehavior, CustomColorPalette, DragDropSelector, Gauge, MenuBar (though it may come back if someone takes an interest in fixing it up and getting something that has a menu bar like Google Docs to adopt it).


 What is DragDropSelector? Can't find anything like that in the source. Don't you mean DragDropDetector?
Reply all
Reply to author
Forward
0 new messages