Closure Library new base.js is broken because typo I guess.

[Daniel Steigerwald]

base.js:566: WARNING - unreachable code.

It seems that there is a typo in https://github.com/google/closure-library/blob/master/closure/goog/base.js#L566 preventing advanced mode verbose compilation without warning.

https://github.com/google/closure-library/issues/336

[Nathan Naze]

+John

Perhaps related to the new module work. This is likely related to the MOE stripping.

Nathan

--

---
You received this message because you are subscribed to the Google Groups "Closure Library Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to closure-library-d...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Nathan Naze]

Preparing a fix. One moment.

[Daniel Steigerwald]

Thank you! Closure Library is awesome and I really appreciate your fast reaction.

[Nathan Naze]

For now, you can strike out the "return null". The canonical source has some legacy logic in this function that is stripped by MOE [1], but recent changes have left the scrubbed version in a bad state.

Thank you for the report.

Nathan

[1] https://code.google.com/p/moe-java/

[Nathan Naze]

fixed in this revision https://github.com/google/closure-library/commit/8f3a53ea581ad3589000c226c8e7b0bce609f1fd